Split IPClusterApp into multiple Application subclasses for each subcommand #80

ipython opened this Issue May 10, 2010 · 2 comments


None yet

2 participants

ipython commented May 10, 2010

Original Launchpad bug 514905: https://bugs.launchpad.net/ipython/+bug/514905
Reported by: ellisonbg (Brian Granger).

IPClusterApp has multiple subcommand (start, list, stop, create). All of these are currently implemented in a single Application subclass. We need to create a common base class that has dispatching to split the different subcommand into their own Application subclasses.

ipython commented May 10, 2010

[ LP comment 1 by: Brian Granger, on 2010-01-31 18:06:48.649680+00:00 ]

This would help resolve some of the difficulties we have in finding and creating cluster directories. If the user gives the --cluster-dir option to specify a cluster_dir, it currrently looks in cwd, but only proceeds if the directory already exists. That is fine for start/stop, but awkward for create as it requires the user to first create the directory using mkdir and then to ipcluster create. Basically, create needs to handle finding the cluster dir differently than start/stop. What is also awkward is that start can also auto create the cluster dir, but it should do so differently than create. But what if ipcluster start is run with the --cluster-dir option?

Splitting IPClusterApp into different sub apps will enable us to better utilize custom logic for each app.

minrk commented Sep 10, 2011

This has been done in 0.11.

@minrk minrk closed this Sep 10, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment