Skip to content
This repository

Ctrl+C during %reset confirm message crash Qtconsole #808

Carreau opened this Issue September 20, 2011 · 5 comments

4 participants

Matthias Bussonnier Min RK Thomas Kluyver Fernando Perez
Matthias Bussonnier

if magic %reset is entered in the QtCOnsole and one press Ctrl+C while the confirmation message is on screen , the QtConsole crash, not on the clasic IPython Console

        339         def callback(line):
        340             self.kernel_manager.stdin_channel.input(line)
    --> 341         self._readline(msg['content']['prompt'], callback=callback)
        343     def _handle_kernel_died(self, since_last_heartbeat):

Don't know if it is linked but issue #348 (%reset doesn't reset prompt number) is still unresolved for me.

Thomas Kluyver

With respect to #348, we decided at some point not to start a new session when you called %reset. Since the prompt number is your position in the session for history, it doesn't get reset either.

Matthias Bussonnier

Sorry about #348 then ... may have read a little to fast while searching for issues concerning %reset magic.

Thomas Kluyver

Don't worry. It was a bug, and it did get fixed, but then we decided it wasn't the right thing to do. I'm not entirely convinced of that, but it works. The thinking, if I remember rightly, was that since we can't do a perfect reset, we shouldn't try, and it should just be a 'clear the namespace' command.

Min RK

This is probably the same as the larger issue described in #745. The message spec allows for requests to succeed or fail, but there are many places in the qt code that make inappropriate assumptions of success - resulting in KeyErrors bringing down the frontend.

Fernando Perez

Assigning it to the 0.12 milestone b/c anything that causes a crash, we should try to clean up before the next release.

Min RK minrk closed this issue from a commit October 24, 2011
Min RK various small fixes in qtconsole
* Don't crash on second stdin request, because it's possible for
  multiple stdin_requests to come in succession (e.g. first was interrupted)
* fix status=abort->aborted typo, and handle aborted executions properly

closes gh-808
Min RK minrk closed this in afeadfc October 24, 2011
Brian E. Granger ellisonbg referenced this issue from a commit January 10, 2012
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.