Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

bad user config shouldn't crash IPython #908

Closed
minrk opened this Issue · 3 comments

2 participants

@minrk
Owner

As described in more general #695.

Steps to crash IPython:

  1. $> ipython --colors bananaphone

Making this part a new Issue, because it should block 0.12.

@minrk
Owner

It principally amounts to catching TraitErrors during initialization.

@fperez
Owner

Tagged for the 0.12 milestone so we notice it as a blocker.

@minrk minrk referenced this issue from a commit in minrk/ipython
@minrk minrk Show invalid config message on TraitErrors during initialization
implemented via @catch_config decorator

Now, the event that was triggered by invalid app config (see `--log-level 5`) is triggered by bad config at any point during initialization.

This *will* catch TraitError bugs in IPython itself, but only during initialization.

closes gh-908
7ed219c
@minrk
Owner

closed by PR #921

@minrk minrk closed this
@ellisonbg ellisonbg referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@mattvonrocketstein mattvonrocketstein referenced this issue from a commit in mattvonrocketstein/ipython
@minrk minrk Show invalid config message on TraitErrors during initialization
implemented via @catch_config decorator

Now, the event that was triggered by invalid app config (see `--log-level 5`) is triggered by bad config at any point during initialization.

This *will* catch TraitError bugs in IPython itself, but only during initialization.

closes gh-908
c9a69f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.