IPython.frontend tests fail without tornado #918

Closed
juliantaylor opened this Issue Oct 21, 2011 · 4 comments

Projects

None yet

3 participants

@juliantaylor

frontend test fails without tornado in git head, it should probably be skipped instead.

IPython/scripts/iptest IPython.frontend -v

Failure: ImportError (The IPython Notebook requires tornado >= 2.1.0) ... ERROR
Do control sequences for clearing the console work? ... ok
Do basic controls sequences for colors work? ... ok
Do xterm-specific control sequences for colors work? ... ok
Do control sequences for scrolling the buffer work? ... ok
Are special characters processed correctly? ... ok
Does the CompletionLexer work for C/C++? ... ok
Does the CompletionLexer work for Python? ... ok
Does the generic kill ring work? ... ok
Does the Qt kill ring work? ... ok
Does the Qt kill ring maintain state with cursor movement? ... ok
Doctest: IPython.frontend.terminal.interactiveshell ... ok
Doctest: IPython.frontend.terminal.interactiveshell.TerminalInteractiveShell.magic_cpaste ... ok

======================================================================
ERROR: Failure: ImportError (The IPython Notebook requires tornado >= 2.1.0)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.7/nose/loader.py", line 390, in loadTestsFromName
    addr.filename, addr.module)
  File "/usr/lib/pymodules/python2.7/nose/importer.py", line 39, in importFromPath
    return self.importFromDir(dir_path, fqname)
  File "/usr/lib/pymodules/python2.7/nose/importer.py", line 86, in importFromDir
    mod = load_module(part_fqname, fh, filename, desc)
  File "/media/Linux-data/home/Packages/ipython/pkg/trunk/IPython/frontend/html/notebook/__init__.py", line 8, in <module>
    raise ImportError(msg)
ImportError: The IPython Notebook requires tornado >= 2.1.0

----------------------------------------------------------------------
Ran 13 tests in 0.163s

FAILED (errors=1)
@minrk
IPython member

IPython.frontend.html is added to the exclusions in the absence of tornado. I don't know why nose is ignoring that, or maybe we are doing it wrong.

@takluyver
IPython member

I remember finding and reporting this some time ago, but it was fixed for me (unless it's got broken in the last day).

@minrk
IPython member

I bumped the version check to 2.2, and confirmed it.

@minrk
IPython member

I think I found it. We skip files, but we don't skip directories, so in cases like this, where __init__ performs an import check, our exclusions do not properly prevent that from happening. PR forthcoming.

@minrk minrk added a commit to minrk/ipython that referenced this issue Nov 2, 2011
@minrk minrk add wantDirectory to ipdoctest, so that directories will be checked f…
…or exclusion

This prevents ImportErrors raised in `__init__` checks from causing a failure when they should have been excluded.

closes gh-918
c3bd3dc
@minrk minrk added a commit that closed this issue Nov 10, 2011
@minrk minrk add wantDirectory to ipdoctest, so that directories will be checked f…
…or exclusion

This prevents ImportErrors raised in `__init__` checks from causing a failure when they should have been excluded.

closes gh-918
closes gh-968
c956c22
@minrk minrk closed this in c956c22 Nov 10, 2011
@mattvonrocketstein mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
@minrk minrk add wantDirectory to ipdoctest, so that directories will be checked f…
…or exclusion

This prevents ImportErrors raised in `__init__` checks from causing a failure when they should have been excluded.

closes gh-918
closes gh-968
e2d2de5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment