Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Test suite must not require any manual interaction #949

Closed
fperez opened this Issue · 2 comments

2 participants

Fernando Perez Thomas Kluyver
Fernando Perez
Owner

I'm pretty sure the merging of #916 is the culprit: now the test suite runs a simple snippet with run -p, which opens the profiler information in the pager. This means that the test suite stops until the user manually closes that pager.

It should always be possible to run the test suite in 100% automated fashion and have it complete. @takluyver, do you think you could have a look? If not I'll do it, but I'm running out of ipython time for the next few days...

One solution is to keep the current run -p test, but temporarily change the pager in that test to be the simple printing pager. In fact, this is probably what we should do unconditionally to the global instance we start in globalipapp for the test suite: it makes no sense at all in the test suite to open the real pager, so we might as well use the dumb print-only pager always in the test suite. This will take care of this problem ever reappearing again in the future triggered by a different codepath.

Thomas Kluyver takluyver was assigned
Thomas Kluyver takluyver referenced this issue from a commit in takluyver/ipython
Thomas Kluyver takluyver Disable the pager for the test suite.
Should fix gh-949
96c843e
Thomas Kluyver takluyver closed this in 71b3a3d
Fernando Perez
Owner

BTW, @takluyver, I never pinged back on this. Many thanks, I can confirm that it does indeed fix this big annoyance!

Thomas Kluyver
Owner

@fperez: You're welcome!

Brian E. Granger ellisonbg referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
matthew von rocketstein mattvonrocketstein referenced this issue from a commit in mattvonrocketstein/ipython
Thomas Kluyver takluyver Disable the pager for the test suite.
closes gh-949
closes gh-961
77b0c8a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.