Do not capture BdbQuit. #10009

Merged
merged 1 commit into from Oct 17, 2016

Projects

None yet

3 participants

@Carreau
Member
Carreau commented Oct 15, 2016

If one want to exit Pdb cleanly, it is possible to just use continue
(or c) that will keep up until a potential next invocation.

Quit is meant to raise an error.

Closes #10006


Thanks @amueller for the report. Would that suit you ?

@Carreau Carreau added this to the 5.2 milestone Oct 15, 2016
@Carreau Carreau Do not capture BdbQuit.
If one want to exit Pdb cleanly, it is possible to just use `continue`
(or `c`) that will keep up until a potential next invocation.

Quit is _meant_ to raise an error.

Closes #10006
97685c5
@amueller

That's raised by calling quit()? And/or by pressing "Ctrl+D"? Then yes.

@minrk minrk merged commit 428e834 into ipython:master Oct 17, 2016

3 checks passed

codecov/patch Coverage not affected when comparing 516e7be...97685c5
Details
codecov/project 73.15% (+0.01%) compared to 516e7be
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@amueller

thanks :)

@takluyver takluyver added a commit that referenced this pull request Jan 12, 2017
@minrk @takluyver minrk + takluyver Backport PR #10009: Do not capture BdbQuit.
If one want to exit Pdb cleanly, it is possible to just use `continue`
(or `c`) that will keep up until a potential next invocation.

Quit is _meant_ to raise an error.

Closes  10006

---

Thanks  amueller for the report. Would that suit you ?

Signed-off-by: Thomas Kluyver <thomas@kluyver.me.uk>
cc5a409
@Carreau Carreau deleted the Carreau:no-ignore-bdbquit branch Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment