/ipython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not capture BdbQuit. #10009

Merged
merged 1 commit into from Oct 17, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  5.2
3 participants
@Carreau @amueller @minrk
@Carreau
Member

Carreau commented Oct 15, 2016

If one want to exit Pdb cleanly, it is possible to just use continue
(or c) that will keep up until a potential next invocation.

Quit is meant to raise an error.

Closes #10006

Thanks @amueller for the report. Would that suit you ?

@Carreau Carreau added this to the 5.2 milestone Oct 15, 2016

@Carreau
Do not capture BdbQuit. 
If one want to exit Pdb cleanly, it is possible to just use `continue`
(or `c`) that will keep up until a potential next invocation.

Quit is _meant_ to raise an error.

Closes #10006
Loading status checks…
97685c5
@amueller

This comment has been minimized.

Show comment
Hide comment
@amueller

amueller Oct 16, 2016

That's raised by calling quit()? And/or by pressing "Ctrl+D"? Then yes.

amueller commented Oct 16, 2016

That's raised by calling quit()? And/or by pressing "Ctrl+D"? Then yes.

@minrk minrk merged commit 428e834 into ipython:master Oct 17, 2016
3 checks passed

3 checks passed

codecov/patch Coverage not affected when comparing 516e7be...97685c5
Details
codecov/project 73.15% (+0.01%) compared to 516e7be
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@amueller

This comment has been minimized.

Show comment
Hide comment
@amueller

amueller Oct 17, 2016

thanks :)

amueller commented Oct 17, 2016

thanks :)

takluyver added a commit that referenced this pull request Jan 12, 2017

@minrk @takluyver
Backport PR #10009: Do not capture BdbQuit. 
If one want to exit Pdb cleanly, it is possible to just use `continue`
(or `c`) that will keep up until a potential next invocation.

Quit is _meant_ to raise an error.

Closes  10006

---

Thanks  amueller for the report. Would that suit you ?

Signed-off-by: Thomas Kluyver <thomas@kluyver.me.uk>
cc5a409

@Carreau Carreau referenced this pull request Feb 13, 2017

Open

impossible to exit debugger traces #10006

@Carreau Carreau deleted the Carreau:no-ignore-bdbquit branch Feb 13, 2017

@joelostblom joelostblom referenced this pull request Feb 25, 2017

Closed

quit does not abort #111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment