New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert debugger 'smart command mode' #10050

Merged
merged 1 commit into from Nov 9, 2016

Conversation

Projects
None yet
3 participants
@takluyver
Member

takluyver commented Nov 9, 2016

This is a manual revert of PR #9449

Closes gh-10037

I don't think there's currently enough support for smart command mode to be worth adding a config option for it now. We can always add this later.

Revert debugger 'smart command mode'
This is a manual revert of PR #9449

Closes gh-10037

I don't think there's currently enough support for smart command mode to
be worth adding a config option for it now. We can always add this
later.

@takluyver takluyver added this to the 5.2 milestone Nov 9, 2016

@Carreau

This comment has been minimized.

Show comment
Hide comment
@Carreau

Carreau Nov 9, 2016

Member

Want to add something to the docs and what's new ?

Member

Carreau commented Nov 9, 2016

Want to add something to the docs and what's new ?

@Carreau

This comment has been minimized.

Show comment
Hide comment
@Carreau

Carreau Nov 9, 2016

Member

Actually we can do it in a separate PR.

Member

Carreau commented Nov 9, 2016

Actually we can do it in a separate PR.

@Carreau Carreau merged commit 5adfb35 into ipython:master Nov 9, 2016

3 checks passed

codecov/patch 100% of diff hit (target 0.00%)
Details
codecov/project 71.16% (+0.01%) compared to 9e2ac10
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

takluyver added a commit that referenced this pull request Jan 12, 2017

Backport PR #10050: Revert debugger 'smart command mode'
This is a manual revert of PR  9449

Closes gh-10037

I don't think there's currently enough support for smart command mode to be worth adding a config option for it now. We can always add this later.

Signed-off-by: Thomas Kluyver <thomas@kluyver.me.uk>
@vladiibine

This comment has been minimized.

Show comment
Hide comment
@vladiibine

vladiibine Feb 4, 2017

Thanks for deleting this! It made it so that variables couldn't be overwritten in debug mode - so sad.

vladiibine commented on 25f7d28 Feb 4, 2017

Thanks for deleting this! It made it so that variables couldn't be overwritten in debug mode - so sad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment