don't use crash_handler by default #1008

Merged
merged 3 commits into from Nov 20, 2011

Conversation

Projects
None yet
2 participants
@minrk
Member

minrk commented Nov 17, 2011

Now the excepthook shows a regular traceback, with a brief message about reporting bugs and how to enable to the big crash handler. Adding a more/0 to interact inside if more:, I get:

In [1]: if 1:
Traceback (most recent call last):
  File "/prefix/bin/ipython", line 9, in <module>
    load_entry_point('ipython==0.12.dev', 'console_scripts', 'ipython')()
  File "/prefix/IPython/frontend/terminal/ipapp.py", line 393, in launch_new_instance
    app.start()
  File "/prefix/IPython/frontend/terminal/ipapp.py", line 367, in start
    self.shell.mainloop()
  File "/prefix/IPython/frontend/terminal/interactiveshell.py", line 220, in mainloop
    self.interact(display_banner=display_banner)
  File "/prefix/IPython/frontend/terminal/interactiveshell.py", line 288, in interact
    more/0
ZeroDivisionError: integer division or modulo by zero

If you suspect this is an IPython bug, please report it at:
    https://github.com/ipython/ipython/issues
or send an email to the mailing list at ipython-dev@scipy.org

You can enable a much more verbose crash handler with:
    %config Application.verbose_crash=True

small fixes along the way:

  • current Application added to configurables list, for use in %config.
  • email addresses in full crash reports changed to ipython-dev, so they don't go straight to individual users.

Should close #695, and ameliorate #833 (doesn't fix the bug, but the message is more sensible)

minrk added some commits Nov 17, 2011

Don't use crash_handler by default
adds crash_handler_lite for adding a short message after a regular
traceback.

Application.verbose_crash configurable determines which to use
@fperez

This comment has been minimized.

Show comment
Hide comment
@fperez

fperez Nov 20, 2011

Member

Great! Code looks clean, tested it. Nice to get rid of those endless crash reports... Merging now.

Member

fperez commented Nov 20, 2011

Great! Code looks clean, tested it. Nice to get rid of those endless crash reports... Merging now.

fperez added a commit that referenced this pull request Nov 20, 2011

Merge pull request #1008 from minrk/excepthook
Use a much more restrained crash handler by default.

Now the excepthook shows a regular traceback, with a brief message about reporting bugs and how to enable to the big crash handler.  Our previous, extremely verbose crash handler can still be activated via `%config Application.verbose_crash=True`, so we can debug real crashes or ask users for extra detail easily.

Small fixes along the way:

* current Application added to configurables list, for use in %config.

* email addresses in full crash reports changed to ipython-dev, so they don't go straight to individual users.

Should close #695, and ameliorate #833 (doesn't fix the bug, but the message is more sensible).

@fperez fperez merged commit 493f6d4 into ipython:master Nov 20, 2011

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

Merge pull request #1008 from minrk/excepthook
Use a much more restrained crash handler by default.

Now the excepthook shows a regular traceback, with a brief message about reporting bugs and how to enable to the big crash handler.  Our previous, extremely verbose crash handler can still be activated via `%config Application.verbose_crash=True`, so we can debug real crashes or ask users for extra detail easily.

Small fixes along the way:

* current Application added to configurables list, for use in %config.

* email addresses in full crash reports changed to ipython-dev, so they don't go straight to individual users.

Should close #695, and ameliorate #833 (doesn't fix the bug, but the message is more sensible).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment