Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove call_tip function and test case for that #10104

Merged
merged 1 commit into from Dec 25, 2016
Merged

Conversation

@srinivasreddy
Copy link
Contributor

srinivasreddy commented Dec 23, 2016

@Carreau
Copy link
Member

Carreau commented Dec 23, 2016

Thanks ! Though there seem to be some use of check_calltip that would need to be removed as well. And I think we want to go through a Deprecation period (ie undocument with @undoc and raise DeprecationWarnings) before removing.

* Add deprecation and warning message for call_tip function

* Remove check_calltip function in tests

* Remove all the tests which use check_calltip to  test 'call_tip' functionality.
@srinivasreddy
Copy link
Contributor Author

srinivasreddy commented Dec 23, 2016

@Carreau pls let me know what do you think!.

@Carreau
Copy link
Member

Carreau commented Dec 25, 2016

Hi @srinivasreddy,

Sorry I mis-expressed myself !

The @undoc and DEPRECATED docstring are great !

I would not have removed the all docstring, and left the test for the later actual removal.
Also the next version of IPython will likely be 6.0 and not 5.2 but you had no way of doing that.

So I'll merge and we can fix things if necessary later !

Thanks ! you contribution are highly appreciated.

@Carreau Carreau merged commit 71426e6 into ipython:master Dec 25, 2016
3 checks passed
3 checks passed
codecov/patch 66.66% of diff hit (target 0.00%)
Details
codecov/project 71.28% (-0.11%) compared to a93ba0e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Carreau Carreau modified the milestone: 6.0 Dec 25, 2016
@srinivasreddy srinivasreddy deleted the srinivasreddy:9102 branch Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.