Fix password hashing for Python 3 #1016

Closed
wants to merge 1 commit into
from

2 participants

@takluyver
IPython member

Correctly handle unicode for Python 3. This may also be needed if you want to use non-ascii characters in passwords with Python 2.

I considered pushing this straight to master, but I wanted to remind people how we're handling Python 3 compatibility. I've used cast_bytes on password, so it can be passed in either as bytes or unicode. The salt is generated in the native str type for each platform, so it goes through str_to_bytes, which is a no-op on Python 2.

I'll merge this tomorrow, unless anyone objects.

@takluyver takluyver added a commit that closed this pull request Nov 20, 2011
@takluyver takluyver Fix password hashing for Python 3
Rebased to avoid recursive merge; closes #1016.
9a89486
@takluyver takluyver closed this in 9a89486 Nov 20, 2011
@fperez
IPython member

Great, thanks!

@mattvonrocketstein mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
@takluyver takluyver Fix password hashing for Python 3
Rebased to avoid recursive merge; closes #1016.
56be6d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment