New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly deprecate limit_to_all #10198

Merged
merged 1 commit into from Jan 26, 2017

Conversation

Projects
None yet
2 participants
@Carreau
Member

Carreau commented Jan 24, 2017

At least emit a warning.

Should likely be backported to 5.x.

@Carreau Carreau added this to the 5.2 milestone Jan 24, 2017

@Carreau

This comment has been minimized.

Show comment
Hide comment
@Carreau

Carreau Jan 26, 2017

Member

Ok I don't like to do this, but i'm going to self merge if there is no reviews.

Member

Carreau commented Jan 26, 2017

Ok I don't like to do this, but i'm going to self merge if there is no reviews.

@takluyver takluyver merged commit 9d720e3 into ipython:master Jan 26, 2017

4 checks passed

codecov/patch 50.00% of diff hit (target 0.00%)
Details
codecov/project 66.22% (-0.01%) compared to 28d41ca
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@takluyver

This comment has been minimized.

Show comment
Hide comment
@takluyver

takluyver Jan 26, 2017

Member

@meeseeksdev backport to 5.x

Member

takluyver commented Jan 26, 2017

@meeseeksdev backport to 5.x

meeseeksdev bot pushed a commit that referenced this pull request Jan 26, 2017

Backport PR #10198: Correctly deprecate limit_to_all
At least emit a warning.

Should likely be backported to 5.x.

@Carreau Carreau deleted the Carreau:limit-all-deprecation branch Jan 26, 2017

Carreau added a commit that referenced this pull request Jan 26, 2017

@Carreau Carreau added the backported label Jan 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment