Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly deprecate limit_to_all #10198

Merged
merged 1 commit into from Jan 26, 2017

Conversation

Carreau
Copy link
Member

@Carreau Carreau commented Jan 24, 2017

At least emit a warning.

Should likely be backported to 5.x.

@Carreau Carreau added this to the 5.2 milestone Jan 24, 2017
@Carreau Carreau force-pushed the limit-all-deprecation branch from f795d32 to 9188007 Compare Jan 24, 2017
@Carreau Carreau force-pushed the limit-all-deprecation branch from 9188007 to 8970389 Compare Jan 24, 2017
@Carreau
Copy link
Member Author

Carreau commented Jan 26, 2017

Ok I don't like to do this, but i'm going to self merge if there is no reviews.

@takluyver takluyver merged commit 9d720e3 into ipython:master Jan 26, 2017
@takluyver
Copy link
Member

@meeseeksdev backport to 5.x

meeseeksdev bot pushed a commit that referenced this pull request Jan 26, 2017
At least emit a warning.

Should likely be backported to 5.x.
@Carreau Carreau deleted the limit-all-deprecation branch Jan 26, 2017
Carreau added a commit that referenced this pull request Jan 26, 2017
@Carreau Carreau added the backported PR that have been backported by MrMeeseeks label Jan 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported PR that have been backported by MrMeeseeks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants