IPython/lib/editorhooks.py: wait for process even if wait=False #10239

Merged
merged 1 commit into from Feb 3, 2017

Conversation

Projects
None yet
3 participants
@segevfiner
Contributor

segevfiner commented Feb 3, 2017

The wait parameter is meant to add a prompt before returning from
the hook for editors that exit immediatly (fork/CreateProcess) but
it accidently prevented waiting at all for the process when it was
False. I think it was meant to be not wait and proc.wait() but we
might as well wait for the process in the wait=True case anyhow. It's
less confusing.

It would be nice if this is backported to 5.x.

IPython/lib/editorhooks.py: wait for process even if wait=False
The wait parameter is meant to add a prompt before returning from
the hook for editors that exit immediatly (fork/CreateProcess) but
it accidently prevented waiting at all for the process when it was
False. I think it was meant to be `not wait and proc.wait()` but we
might as well wait for the process in the `wait=True` case anyhow. It's
less confusing.

@takluyver takluyver added this to the 5.3 milestone Feb 3, 2017

@takluyver takluyver merged commit e311b1d into ipython:master Feb 3, 2017

4 checks passed

codecov/patch 100% of diff hit (target 0%)
Details
codecov/project 66.28% (+<.01%) compared to e834116
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@takluyver

This comment has been minimized.

Show comment
Hide comment
@takluyver

takluyver Feb 3, 2017

Member

Thanks, this seems reasonable.

Member

takluyver commented Feb 3, 2017

Thanks, this seems reasonable.

@segevfiner segevfiner deleted the segevfiner:editorhooks-wait-fix branch Feb 3, 2017

@takluyver

This comment has been minimized.

Show comment
Hide comment
@takluyver

takluyver Feb 3, 2017

Member

@meeseeksdev backport to 5.x

Member

takluyver commented Feb 3, 2017

@meeseeksdev backport to 5.x

meeseeksdev bot pushed a commit that referenced this pull request Feb 3, 2017

Backport PR #10239: IPython/lib/editorhooks.py: wait for process even…
… if wait=False

The wait parameter is meant to add a prompt before returning from
the hook for editors that exit immediatly (fork/CreateProcess) but
it accidently prevented waiting at all for the process when it was
False. I think it was meant to be `not wait and proc.wait()` but we
might as well wait for the process in the `wait=True` case anyhow. It's
less confusing.

It would be nice if this is backported to 5.x.

takluyver added a commit that referenced this pull request Feb 3, 2017

@Carreau Carreau added the backported label Feb 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment