Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Backport PR #10239 on branch 5.x #10240
Backport PR #10239: IPython/lib/editorhooks.py: wait for process even if wait=False
The wait parameter is meant to add a prompt before returning from
It would be nice if this is backported to 5.x.
… if wait=False The wait parameter is meant to add a prompt before returning from the hook for editors that exit immediatly (fork/CreateProcess) but it accidently prevented waiting at all for the process when it was False. I think it was meant to be `not wait and proc.wait()` but we might as well wait for the process in the `wait=True` case anyhow. It's less confusing. It would be nice if this is backported to 5.x.