Backport PR #10239 on branch 5.x #10240

Merged
merged 1 commit into from Feb 3, 2017

Conversation

Projects
None yet
2 participants
@meeseeksdev

meeseeksdev bot commented Feb 3, 2017

Backport PR #10239: IPython/lib/editorhooks.py: wait for process even if wait=False

The wait parameter is meant to add a prompt before returning from
the hook for editors that exit immediatly (fork/CreateProcess) but
it accidently prevented waiting at all for the process when it was
False. I think it was meant to be not wait and proc.wait() but we
might as well wait for the process in the wait=True case anyhow. It's
less confusing.

It would be nice if this is backported to 5.x.

Backport PR #10239: IPython/lib/editorhooks.py: wait for process even…
… if wait=False

The wait parameter is meant to add a prompt before returning from
the hook for editors that exit immediatly (fork/CreateProcess) but
it accidently prevented waiting at all for the process when it was
False. I think it was meant to be `not wait and proc.wait()` but we
might as well wait for the process in the `wait=True` case anyhow. It's
less confusing.

It would be nice if this is backported to 5.x.

@meeseeksdev meeseeksdev bot added this to the 5.3 milestone Feb 3, 2017

@takluyver takluyver merged commit b819394 into 5.x Feb 3, 2017

4 checks passed

codecov/patch 100% of diff hit (target 0%)
Details
codecov/project 66.04% (+<.01%) compared to 0a31c27
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@takluyver takluyver deleted the auto-backport-of-pr-10239 branch Feb 3, 2017

@Carreau Carreau added the backported label Feb 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment