Dollar escape #1025

Merged
merged 3 commits into from Nov 22, 2011

Conversation

Projects
None yet
2 participants
@takluyver
Member

takluyver commented Nov 21, 2011

As pointed out by @stefanv and @minrk on #822, it should be possible to use a raw $ in shell commands, e.g. for environment variables. This allows that, with the "$$HOME" syntax.

@minrk

This comment has been minimized.

Show comment
Hide comment
@minrk

minrk Nov 22, 2011

Member

Looks good to me. Do you want to add a test to cover '${foo}' -> '$bar'? That's one probably quite rare use case that I've had to deal with long ago, where the shell variable name is a Python variable you want to expand. This works just fine right now with the syntax above, but we might add the test case anyway.

Member

minrk commented Nov 22, 2011

Looks good to me. Do you want to add a test to cover '${foo}' -> '$bar'? That's one probably quite rare use case that I've had to deal with long ago, where the shell variable name is a Python variable you want to expand. This works just fine right now with the syntax above, but we might add the test case anyway.

@takluyver

This comment has been minimized.

Show comment
Hide comment
@takluyver

takluyver Nov 22, 2011

Member

Yep, good idea. Done.

Member

takluyver commented Nov 22, 2011

Yep, good idea. Done.

@minrk

This comment has been minimized.

Show comment
Hide comment
@minrk

minrk Nov 22, 2011

Member

Thanks, I say go ahead and merge.

Member

minrk commented Nov 22, 2011

Thanks, I say go ahead and merge.

@takluyver takluyver merged commit aa30a66 into ipython:master Nov 22, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment