Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix the rest of the colors used on Windows so they are more visible #10260
If this fix is acceptable it would be nice if this is backported to IPython 5 as this is very visible. Every user I see using IPython on Windows sees this and most don't seem to understand that they can change it. And on top of that this is especially annoying when using IPython on a computer you don't own or a VM. Having to reconfigure on each one...
Thanks for merging!
You milestoned this as 6.0. Are you sure you don't want this in 5.x? Considering that 7b7d560 is already in 5.x and this pull request essentially completes it, and also fixes the prompt numbers so they look like they used to in IPython 4 and below.
Since 5 (LTS) is the last version to support Python 2.7, many will be using it for quite a while even after 6.0 is out, maybe even using both versions at the same time since they work with both Python 2 and Python 3. Considering this, it will be nice if IPython 5 on Windows uses the same colors as IPython 6+ on Windows, otherwise it would look quite weird for a user that uses both versions that the colors are different and it's nicer if the user doesn't have to use custom configuration to make them the same (At least as long IPython 5/6 and later use the same highlighting system).