Indent on new line by looking at the text before the cursor. #10264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that would allow edit like the following to insert the right amount of
space on the newline (`|` is the cursor)
class Bar:
def __init__(self):|<enter>
self.filed=0
Instead of inserting a blank line with 0 space.
Closes ipython#9283
Carreau
commented
Feb 9, 2017
| d.cursor_position_row >= d.line_count - d.empty_line_count_at_the_end() | ||
| ): | ||
| b.insert_text('\n' + (' ' * (indent or 0))) | ||
| return |
There was a problem hiding this comment.
ALso I'm unsure, but it seem to me that this block is completely redundant and can be remove. It is taken care of by the block below. (this is due to the fact that we cut the text at the cursor position, so status will never be 'ready'
There was a problem hiding this comment.
Scratch that.
In [1]: def foo():
...: pass
...: |<enter>
...: def bar():
...: pass
Above example insert a new line with this patch.
Execute if I remove above block.
Carreau
added a commit
to Carreau/ipython
that referenced
this pull request
Feb 9, 2017
Closes ipython#9588 Similar to ipython#10264, but with a simpler logic as we never execute.
Carreau
added a commit
to Carreau/ipython
that referenced
this pull request
Feb 9, 2017
Closes ipython#9588 Similar to ipython#10264, but with a simpler logic as we never execute.
Carreau
added a commit
to Carreau/ipython
that referenced
this pull request
Feb 9, 2017
Closes ipython#9588 Similar to ipython#10264, but with a simpler logic as we never execute.
|
@meeseeksdev backport to 5.x |
lumberbot-app bot
pushed a commit
that referenced
this pull request
Feb 9, 2017
…the cursor.
that would allow edit like the following to insert the right amount of
space on the newline (`|` is the cursor)
class Bar:
def __init__(self):|<enter>
self.filed=0
Instead of inserting a blank line with 0 space.
Closes 9283
---
takluyver can you have a look ?
Carreau
added a commit
that referenced
this pull request
Feb 9, 2017
Backport PR #10264 on branch 5.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that would allow edit like the following to insert the right amount of
space on the newline (
|is the cursor)Instead of inserting a blank line with 0 space.
Closes #9283
@takluyver can you have a look ?