Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #10260 on branch 5.x #10281

Merged
merged 1 commit into from Feb 10, 2017
Merged

Backport PR #10260 on branch 5.x #10281

merged 1 commit into from Feb 10, 2017

Conversation

lumberbot-app[bot]
Copy link
Contributor

@lumberbot-app lumberbot-app bot commented Feb 9, 2017

Backport PR #10260: Fix the rest of the colors used on Windows so they are more visible

This applies a hack similar to the one in
7b7d560 to change the prompt colors
and exception colors so they are more visible as shown in issue 10238

If this fix is acceptable it would be nice if this is backported to IPython 5 as this is very visible. Every user I see using IPython on Windows sees this and most don't seem to understand that they can change it. And on top of that this is especially annoying when using IPython on a computer you don't own or a VM. Having to reconfigure on each one...

Fixes: 10238

…y are more visible

This applies a hack similar to the one in
7b7d560 to change the prompt colors
and exception colors so they are more visible as shown in issue  10238

If this fix is acceptable it would be nice if this is backported to IPython 5 as this is very visible. Every user I see using IPython on Windows sees this and most don't seem to understand that they can change it. And on top of that this is especially annoying when using IPython on a computer you don't own or a VM. Having to reconfigure on each one...

Fixes:  10238
@lumberbot-app lumberbot-app bot added this to the 5.3 milestone Feb 9, 2017
@minrk minrk merged commit 1275237 into 5.x Feb 10, 2017
@minrk minrk deleted the auto-backport-of-pr-10260 branch February 10, 2017 10:27
@Carreau Carreau added the backported PR that have been backported by MrMeeseeks label Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported PR that have been backported by MrMeeseeks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants