Backport PR #10260 on branch 5.x #10281

Merged
merged 1 commit into from Feb 10, 2017

Conversation

Projects
None yet
2 participants
@meeseeksdev

meeseeksdev bot commented Feb 9, 2017

Backport PR #10260: Fix the rest of the colors used on Windows so they are more visible

This applies a hack similar to the one in
7b7d560 to change the prompt colors
and exception colors so they are more visible as shown in issue 10238

If this fix is acceptable it would be nice if this is backported to IPython 5 as this is very visible. Every user I see using IPython on Windows sees this and most don't seem to understand that they can change it. And on top of that this is especially annoying when using IPython on a computer you don't own or a VM. Having to reconfigure on each one...

Fixes: 10238

Backport PR #10260: Fix the rest of the colors used on Windows so the…
…y are more visible

This applies a hack similar to the one in
7b7d560 to change the prompt colors
and exception colors so they are more visible as shown in issue  10238

If this fix is acceptable it would be nice if this is backported to IPython 5 as this is very visible. Every user I see using IPython on Windows sees this and most don't seem to understand that they can change it. And on top of that this is especially annoying when using IPython on a computer you don't own or a VM. Having to reconfigure on each one...

Fixes:  10238

@meeseeksdev meeseeksdev bot added this to the 5.3 milestone Feb 9, 2017

@minrk minrk merged commit 1275237 into 5.x Feb 10, 2017

4 checks passed

codecov/patch 40% of diff hit (target 0%)
Details
codecov/project 66.04% (-0.01%) compared to 6011b49
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@minrk minrk deleted the auto-backport-of-pr-10260 branch Feb 10, 2017

@Carreau Carreau added the backported label Feb 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment