Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #10301 on branch 5.x #10311

Merged
merged 1 commit into from Feb 21, 2017
Merged

Backport PR #10301 on branch 5.x #10311

merged 1 commit into from Feb 21, 2017

Conversation

@meeseeksdev
Copy link
Contributor

meeseeksdev bot commented Feb 21, 2017

Backport PR #10301: FIX: re-order qt eventloop hook a bit

try to reduce race conditions by:

  • connect the exit callback before enabling the notifier (this might
    not matter)
  • only bother starting the event loop if the input is not ready.

closes 10201

I don't have a mac to test this on. This may be complete cargo-culting.

try to reduce race conditions by:

 - connect the exit callback before enabling the notifier (this might
   not matter)
 - only bother starting the event loop if the input is not ready.

closes  10201

I don't have a mac to test this on.  This may be complete cargo-culting.
@meeseeksdev meeseeksdev bot added this to the 5.3 milestone Feb 21, 2017
@Carreau Carreau merged commit 07bdb40 into 5.x Feb 21, 2017
4 checks passed
4 checks passed
codecov/patch 0% of diff hit (target 0%)
Details
codecov/project 66.04% (+<.01%) compared to 1275237
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Carreau Carreau added the backported label Feb 21, 2017
@takluyver takluyver deleted the auto-backport-of-pr-10301 branch Apr 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.