Allow reloads of Enums. #10316

Merged
merged 1 commit into from Feb 22, 2017

Conversation

Projects
None yet
3 participants
@Carreau
Member

Carreau commented Feb 21, 2017

Closes #10232

+ """))
+ with tt.AssertNotPrints(('[autoreload of %s failed:' % mod_name), channel='stderr'):
+ self.shell.run_code("pass") # trigger another reload
+ except ImportError:

This comment has been minimized.

@takluyver

takluyver Feb 22, 2017

Member

Given that autoreload uses import machinery, let's not catch ImportError around this test. ;-) We can just catch it on import enum at first and skip the test if that fails.

@takluyver

takluyver Feb 22, 2017

Member

Given that autoreload uses import machinery, let's not catch ImportError around this test. ;-) We can just catch it on import enum at first and skip the test if that fails.

@Carreau

This comment has been minimized.

Show comment
Hide comment
@Carreau

Carreau Feb 22, 2017

Member

replaced by a skipif < 3.6

Member

Carreau commented Feb 22, 2017

replaced by a skipif < 3.6

@takluyver takluyver added this to the 6.0 milestone Feb 22, 2017

@takluyver takluyver merged commit b937052 into ipython:master Feb 22, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Carreau

This comment has been minimized.

Show comment
Hide comment
@Carreau

Carreau Feb 22, 2017

Member

Thanks !

Member

Carreau commented Feb 22, 2017

Thanks !

@Carreau Carreau deleted the Carreau:autoreload-enum branch Feb 22, 2017

@Apteryks

This comment has been minimized.

Show comment
Hide comment
@Apteryks

Apteryks Jun 7, 2017

Hi, and thanks for fixing this problem :). Is it planned for this change to be backported to 5.X version in the future?

Apteryks commented Jun 7, 2017

Hi, and thanks for fixing this problem :). Is it planned for this change to be backported to 5.X version in the future?

@Carreau

This comment has been minimized.

Show comment
Hide comment
@Carreau

Carreau Jun 7, 2017

Member

Hi, and thanks for fixing this problem :). Is it planned for this change to be backported to 5.X version in the future?

Backport to 5.x has not beed requested (as we sort of assume user of Python 3 will have 6.x branch). but if you submit a PR against the 5.x branch that backport this fix, we'll be happy to merge it.

Member

Carreau commented Jun 7, 2017

Hi, and thanks for fixing this problem :). Is it planned for this change to be backported to 5.X version in the future?

Backport to 5.x has not beed requested (as we sort of assume user of Python 3 will have 6.x branch). but if you submit a PR against the 5.x branch that backport this fix, we'll be happy to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment