Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reloads of Enums. #10316

Merged
merged 1 commit into from Feb 22, 2017
Merged

Allow reloads of Enums. #10316

merged 1 commit into from Feb 22, 2017

Conversation

@Carreau
Copy link
Member

@Carreau Carreau commented Feb 21, 2017

Closes #10232

@Carreau Carreau force-pushed the Carreau:autoreload-enum branch from 7fe87b3 to 7c27c04 Feb 21, 2017
"""))
with tt.AssertNotPrints(('[autoreload of %s failed:' % mod_name), channel='stderr'):
self.shell.run_code("pass") # trigger another reload
except ImportError:

This comment has been minimized.

@takluyver

takluyver Feb 22, 2017
Member

Given that autoreload uses import machinery, let's not catch ImportError around this test. ;-) We can just catch it on import enum at first and skip the test if that fails.

Closes #10232
@Carreau Carreau force-pushed the Carreau:autoreload-enum branch from 7c27c04 to ca28d07 Feb 22, 2017
@Carreau
Copy link
Member Author

@Carreau Carreau commented Feb 22, 2017

replaced by a skipif < 3.6

@takluyver takluyver added this to the 6.0 milestone Feb 22, 2017
@takluyver takluyver merged commit b937052 into ipython:master Feb 22, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Carreau
Copy link
Member Author

@Carreau Carreau commented Feb 22, 2017

Thanks !

@Carreau Carreau deleted the Carreau:autoreload-enum branch Feb 22, 2017
@Apteryks
Copy link

@Apteryks Apteryks commented Jun 7, 2017

Hi, and thanks for fixing this problem :). Is it planned for this change to be backported to 5.X version in the future?

@Carreau
Copy link
Member Author

@Carreau Carreau commented Jun 7, 2017

Hi, and thanks for fixing this problem :). Is it planned for this change to be backported to 5.X version in the future?

Backport to 5.x has not beed requested (as we sort of assume user of Python 3 will have 6.x branch). but if you submit a PR against the 5.x branch that backport this fix, we'll be happy to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.