Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAttempt at fixing assertion from reverse search #10371
Merged
Conversation
IPython/terminal/interactiveshell.py
Outdated
| @@ -239,7 +239,7 @@ def prompt(): | |||
| # Ignore blank lines and consecutive duplicates | |||
| cell = cell.rstrip() | |||
| if cell and (cell != last_cell): | |||
| history.append(cell) | |||
| history.append(cast_unicode_py2(cell)) | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
takluyver
Mar 6, 2017
Author
Member
Done. I'd still like someone to validate that this actually fixes the issue, though...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
takluyver commentedMar 2, 2017
Trying to fix gh-10014, though I can't reproduce the problem to test it.
PR against 5.x because I think this is only needed for Python 2.