Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt at fixing assertion from reverse search #10371

Merged
merged 2 commits into from Mar 9, 2017
Merged

Conversation

takluyver
Copy link
Member

@takluyver takluyver commented Mar 2, 2017

Trying to fix gh-10014, though I can't reproduce the problem to test it.

PR against 5.x because I think this is only needed for Python 2.

Trying to fix ipythongh-10014, though I can't reproduce the problem to test it.

PR against 5.x because I think this is only needed for Python 2.
@takluyver takluyver added this to the 5.4 milestone Mar 2, 2017
@takluyver takluyver added the bug label Mar 2, 2017
@@ -239,7 +239,7 @@ def prompt():
# Ignore blank lines and consecutive duplicates
cell = cell.rstrip()
if cell and (cell != last_cell):
history.append(cell)
history.append(cast_unicode_py2(cell))
Copy link
Member

@minrk minrk Mar 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be done at history_manager.get_tail?

Copy link
Member Author

@takluyver takluyver Mar 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I'd still like someone to validate that this actually fixes the issue, though...

@minrk minrk merged commit 3904721 into ipython:5.x Mar 9, 2017
3 checks passed
@takluyver takluyver deleted the i10014 branch Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants