New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt at fixing assertion from reverse search #10371

Merged
merged 2 commits into from Mar 9, 2017

Conversation

Projects
None yet
2 participants
@takluyver
Member

takluyver commented Mar 2, 2017

Trying to fix gh-10014, though I can't reproduce the problem to test it.

PR against 5.x because I think this is only needed for Python 2.

Attempt at fixing assertion from reverse search
Trying to fix gh-10014, though I can't reproduce the problem to test it.

PR against 5.x because I think this is only needed for Python 2.

@takluyver takluyver added this to the 5.4 milestone Mar 2, 2017

@takluyver takluyver added the bug label Mar 2, 2017

Show outdated Hide outdated IPython/terminal/interactiveshell.py
@@ -239,7 +239,7 @@ def prompt():
# Ignore blank lines and consecutive duplicates
cell = cell.rstrip()
if cell and (cell != last_cell):
history.append(cell)
history.append(cast_unicode_py2(cell))

This comment has been minimized.

@minrk

minrk Mar 5, 2017

Member

Should this be done at history_manager.get_tail?

@minrk

minrk Mar 5, 2017

Member

Should this be done at history_manager.get_tail?

This comment has been minimized.

@takluyver

takluyver Mar 6, 2017

Member

Done. I'd still like someone to validate that this actually fixes the issue, though...

@takluyver

takluyver Mar 6, 2017

Member

Done. I'd still like someone to validate that this actually fixes the issue, though...

@minrk minrk merged commit 3904721 into ipython:5.x Mar 9, 2017

3 checks passed

codecov/patch 100% of diff hit (target 0%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +33.97% compared to 8560d51
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@takluyver takluyver deleted the takluyver:i10014 branch Mar 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment