Skip to content
This repository

Notebook: don't change cell when selecting code using shift+up/down. #1038

Closed
wants to merge 1 commit into from

2 participants

Thomas Kluyver Fernando Perez
Thomas Kluyver
Collaborator

Closes gh-787

Fernando Perez
Owner

Awesome, thanks! Merged and pushed.

Fernando Perez fperez closed this November 24, 2011
Fernando Perez
Owner

mmh, auto-close not working... closing manually.

Stefan van der Walt stefanv referenced this pull request from a commit in stefanv/ipython November 24, 2011
Thomas Kluyver Notebook: don't change cell when selecting code using shift+up/down.
Closes gh-787; closes gh-1038 (rebased to prevent recursive merge).
807f914
Fernando Perez fperez referenced this pull request from a commit January 10, 2012
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Nov 24, 2011
Thomas Kluyver Notebook: don't change cell when selecting code using shift+up/down.
Closes gh-787
ab41cc4
This page is out of date. Refresh to see the latest.
4  IPython/frontend/html/notebook/static/js/notebook.js
@@ -65,13 +65,13 @@ var IPython = (function (IPython) {
65 65
                 // websocket connection with firefox
66 66
                 event.preventDefault();
67 67
             }
68  
-            if (event.which === 38) {
  68
+            if (event.which === 38 && !event.shiftKey) {
69 69
                 var cell = that.selected_cell();
70 70
                 if (cell.at_top()) {
71 71
                     event.preventDefault();
72 72
                     that.select_prev();
73 73
                 };
74  
-            } else if (event.which === 40) {
  74
+            } else if (event.which === 40 && !event.shiftKey) {
75 75
                 var cell = that.selected_cell();
76 76
                 if (cell.at_bottom()) {
77 77
                     event.preventDefault();
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.