Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Notebook: don't change cell when selecting code using shift+up/down. #1038

Closed
wants to merge 1 commit into from

2 participants

@takluyver
Owner

Closes gh-787

@fperez
Owner

Awesome, thanks! Merged and pushed.

@fperez
Owner

mmh, auto-close not working... closing manually.

@fperez fperez closed this
@stefanv stefanv referenced this pull request from a commit in stefanv/ipython
@takluyver takluyver Notebook: don't change cell when selecting code using shift+up/down.
Closes gh-787; closes gh-1038 (rebased to prevent recursive merge).
807f914
@fperez fperez referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
@mattvonrocketstein mattvonrocketstein referenced this pull request from a commit in mattvonrocketstein/ipython
@takluyver takluyver Notebook: don't change cell when selecting code using shift+up/down.
Closes gh-787; closes gh-1038 (rebased to prevent recursive merge).
7c19a22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +2 −2 IPython/frontend/html/notebook/static/js/notebook.js
View
4 IPython/frontend/html/notebook/static/js/notebook.js
@@ -65,13 +65,13 @@ var IPython = (function (IPython) {
// websocket connection with firefox
event.preventDefault();
}
- if (event.which === 38) {
+ if (event.which === 38 && !event.shiftKey) {
var cell = that.selected_cell();
if (cell.at_top()) {
event.preventDefault();
that.select_prev();
};
- } else if (event.which === 40) {
+ } else if (event.which === 40 && !event.shiftKey) {
var cell = that.selected_cell();
if (cell.at_bottom()) {
event.preventDefault();
Something went wrong with that request. Please try again.