New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up shutdown by eliminating unnecessary sleeping #10408

Merged
merged 1 commit into from Mar 25, 2017

Conversation

Projects
None yet
3 participants
@lpsinger
Contributor

lpsinger commented Mar 24, 2017

Eliminate an annoying split-second pause when closing a shell session by reducing unnecessary sleeps while killing background scripts. If there are no bacgkround scripts running, or if they shut down on the first or second attempt, then we can eliminate some pauses.

Speed up shutdown by eliminating unnecessary sleeping
Eliminate an annoying split-second pause when closing a shell session
by reducing unnecessary sleeps while killing background scripts.
If there are no bacgkround scripts running, or if they shut down on
the first or second attempt, then we can eliminate some pauses.

@takluyver takluyver added this to the 5.4 milestone Mar 25, 2017

@takluyver

This comment has been minimized.

Show comment
Hide comment
@takluyver

takluyver Mar 25, 2017

Member

Thanks!

Member

takluyver commented Mar 25, 2017

Thanks!

@takluyver takluyver merged commit bf1efa0 into ipython:master Mar 25, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@takluyver

This comment has been minimized.

Show comment
Hide comment
@takluyver

takluyver Mar 25, 2017

Member

@meeseeksdev backport

Member

takluyver commented Mar 25, 2017

@meeseeksdev backport

meeseeksdev bot pushed a commit that referenced this pull request Mar 25, 2017

Backport PR #10408: Speed up shutdown by eliminating unnecessary slee…
…ping

Eliminate an annoying split-second pause when closing a shell session by reducing unnecessary sleeps while killing background scripts. If there are no bacgkround scripts running, or if they shut down on the first or second attempt, then we can eliminate some pauses.

takluyver added a commit that referenced this pull request Mar 25, 2017

@lpsinger lpsinger deleted the lpsinger:faster-shutdown-bg-scripts branch Mar 27, 2017

@Carreau Carreau added the backported label May 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment