Skip to content
This repository

fix firefox (windows) break line on empty prompt number #1042

Closed
wants to merge 1 commit into from

2 participants

Matthias Bussonnier Fernando Perez
Matthias Bussonnier
Collaborator

Firefox on windows sometime put the end of the prompt on a new line.
This should fix it (hopefully)

Sorry it's github-edited

Fernando Perez
Owner

Great, thanks! I'd also noticed it on ffox in linux, and it was very annoying. I rebased to avoid a recursive merge for just one commit, pushed as e87124e. Keep up the great work!

Fernando Perez fperez closed this November 25, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Nov 25, 2011
Matthias Bussonnier fix firefox (windows) break line on empty prompt number 7ff855c
This page is out of date. Refresh to see the latest.
4  IPython/frontend/html/notebook/static/js/codecell.js
@@ -15,7 +15,7 @@ var IPython = (function (IPython) {
15 15
 
16 16
     var CodeCell = function (notebook) {
17 17
         this.code_mirror = null;
18  
-        this.input_prompt_number = ' ';
  18
+        this.input_prompt_number = ' ';
19 19
         this.is_completing = false;
20 20
         this.completion_cursor = null;
21 21
         this.outputs = [];
@@ -588,7 +588,7 @@ var IPython = (function (IPython) {
588 588
     };
589 589
 
590 590
     CodeCell.prototype.set_input_prompt = function (number) {
591  
-        var n = number || ' ';
  591
+        var n = number || ' ';
592 592
         this.input_prompt_number = n
593 593
         this.element.find('div.input_prompt').html('In [' + n + ']:');
594 594
     };
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.