Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype: show signature with Jedi. #10507

Merged
merged 1 commit into from Jun 5, 2017
Merged

Conversation

@Carreau
Copy link
Member

@Carreau Carreau commented May 5, 2017

That (unsurprisingly), change the APIs that were marked as unstable for 6.0.
Not in a big way.

In the terminal I stick the signature of functions (not callables, sorry numpy ufuncs..) into the meta-display (ie, next to the type), which make multicolumn compact (you see the sig only when selecting), and column a bit ugly, sig still in the type in the right column.

sig

@takluyver
Copy link
Member

@takluyver takluyver commented May 8, 2017

Neat :-)

@takluyver
Copy link
Member

@takluyver takluyver commented May 8, 2017

Do you want to land this as is so we can start playing with it, or do more on it first? There's nothing obviously amiss with the code, but I haven't used Jedi enough to really understand everything on that side.

@takluyver takluyver added this to the 6.1 milestone May 8, 2017
@Carreau
Copy link
Member Author

@Carreau Carreau commented May 8, 2017

I need to check it works with jedi stable (at least don't crash) and cleanup a bit/document/test.
I'm at the same time working on a patch to ipykernel (and nteract) to show this... but UI is hard.

@Carreau Carreau force-pushed the Carreau:jedi-signature branch from eac8d9f to d4b99eb May 8, 2017
@Carreau Carreau modified the milestones: 6.1, 6.2 May 24, 2017
@Carreau Carreau force-pushed the Carreau:jedi-signature branch 2 times, most recently from 5a44708 to 39b6e4c Jun 1, 2017
@Carreau
Copy link
Member Author

@Carreau Carreau commented Jun 1, 2017

Updated, cleaned, rebased, documented, tested.

Now that 6.1 is out I'm happy to get that in .

@Carreau Carreau force-pushed the Carreau:jedi-signature branch 3 times, most recently from 7c7a0dc to 6992964 Jun 1, 2017
When completion are function, jedi is capable of giving us the function
signature. This adds a signature field to the (still unstable) completer
API and make use of it in the IPython terminal UI.

It is not (yet) exposed by the ipykernel.

Additionally add typing to a couple of locations.
@Carreau Carreau force-pushed the Carreau:jedi-signature branch from 6992964 to e8c3f90 Jun 5, 2017
@Carreau
Copy link
Member Author

@Carreau Carreau commented Jun 5, 2017

Test fixed, just a small typo.
I'm going to get that in to have a chance to get if tested a bit.

@Carreau Carreau merged commit bd3142f into ipython:master Jun 5, 2017
4 checks passed
4 checks passed
codecov/patch 78.37% of diff hit (target 0%)
Details
codecov/project 66.91% (+0.01%) compared to 57cf9b1
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Carreau Carreau deleted the Carreau:jedi-signature branch Jun 5, 2017
lgeiger added a commit to lgeiger/ipykernel that referenced this pull request Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.