Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPrototype: show signature with Jedi. #10507
Merged
Conversation
|
Neat :-) |
|
Do you want to land this as is so we can start playing with it, or do more on it first? There's nothing obviously amiss with the code, but I haven't used Jedi enough to really understand everything on that side. |
|
I need to check it works with jedi stable (at least don't crash) and cleanup a bit/document/test. |
Carreau
force-pushed the
Carreau:jedi-signature
branch
2 times, most recently
from
5a44708
to
39b6e4c
|
Updated, cleaned, rebased, documented, tested. Now that 6.1 is out I'm happy to get that in . |
Carreau
force-pushed the
Carreau:jedi-signature
branch
3 times, most recently
from
7c7a0dc
to
6992964
When completion are function, jedi is capable of giving us the function signature. This adds a signature field to the (still unstable) completer API and make use of it in the IPython terminal UI. It is not (yet) exposed by the ipykernel. Additionally add typing to a couple of locations.
|
Test fixed, just a small typo. |
lgeiger
added a commit
to lgeiger/ipykernel
that referenced
this pull request
Jun 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
That (unsurprisingly), change the APIs that were marked as unstable for 6.0.
Not in a big way.
In the terminal I stick the signature of functions (not callables, sorry numpy ufuncs..) into the meta-display (ie, next to the type), which make multicolumn compact (you see the sig only when selecting), and column a bit ugly, sig still in the type in the right column.