Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upPrototype: show signature with Jedi. #10507
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Neat :-) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
takluyver
May 8, 2017
Member
Do you want to land this as is so we can start playing with it, or do more on it first? There's nothing obviously amiss with the code, but I haven't used Jedi enough to really understand everything on that side.
|
Do you want to land this as is so we can start playing with it, or do more on it first? There's nothing obviously amiss with the code, but I haven't used Jedi enough to really understand everything on that side. |
takluyver
added this to the 6.1 milestone
May 8, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Carreau
May 8, 2017
Member
I need to check it works with jedi stable (at least don't crash) and cleanup a bit/document/test.
I'm at the same time working on a patch to ipykernel (and nteract) to show this... but UI is hard.
|
I need to check it works with jedi stable (at least don't crash) and cleanup a bit/document/test. |
Carreau
modified the milestones:
6.1,
6.2
May 24, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Carreau
Jun 1, 2017
Member
Updated, cleaned, rebased, documented, tested.
Now that 6.1 is out I'm happy to get that in .
|
Updated, cleaned, rebased, documented, tested. Now that 6.1 is out I'm happy to get that in . |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Carreau
Jun 5, 2017
Member
Test fixed, just a small typo.
I'm going to get that in to have a chance to get if tested a bit.
|
Test fixed, just a small typo. |
Carreau
merged commit bd3142f
into
ipython:master
Jun 5, 2017
Carreau
deleted the
Carreau:jedi-signature
branch
Jun 5, 2017
added a commit
to lgeiger/ipykernel
that referenced
this pull request
Jun 6, 2017
Carreau commentedMay 5, 2017
That (unsurprisingly), change the APIs that were marked as unstable for 6.0.
Not in a big way.
In the terminal I stick the signature of functions (not callables, sorry numpy ufuncs..) into the meta-display (ie, next to the type), which make multicolumn compact (you see the sig only when selecting), and column a bit ugly, sig still in the type in the right column.