New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prototype: show signature with Jedi. #10507
Conversation
Neat :-) |
Do you want to land this as is so we can start playing with it, or do more on it first? There's nothing obviously amiss with the code, but I haven't used Jedi enough to really understand everything on that side. |
I need to check it works with jedi stable (at least don't crash) and cleanup a bit/document/test. |
5a44708
to
39b6e4c
Compare
Updated, cleaned, rebased, documented, tested. Now that 6.1 is out I'm happy to get that in . |
7c7a0dc
to
6992964
Compare
When completion are function, jedi is capable of giving us the function signature. This adds a signature field to the (still unstable) completer API and make use of it in the IPython terminal UI. It is not (yet) exposed by the ipykernel. Additionally add typing to a couple of locations.
Test fixed, just a small typo. |
That (unsurprisingly), change the APIs that were marked as unstable for 6.0.
Not in a big way.
In the terminal I stick the signature of functions (not callables, sorry numpy ufuncs..) into the meta-display (ie, next to the type), which make multicolumn compact (you see the sig only when selecting), and column a bit ugly, sig still in the type in the right column.