Skip to content

Don't reload __mp_main__ #10523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2017
Merged

Conversation

lukepfister
Copy link
Contributor

Fixes #10522.

@takluyver
Copy link
Member

I don't particularly understand why the previous attempt at a fix (#8568) didn't fix this, but this seems reasonable to me.

@takluyver takluyver requested a review from Carreau May 10, 2017 13:56
@Carreau
Copy link
Member

Carreau commented May 10, 2017

I don't think we really understand why, so I'm incline to merge as is.

5.x ?

@takluyver takluyver added this to the 5.4 milestone May 10, 2017
@takluyver
Copy link
Member

Yep, backporting to 5.x sounds reasonable.

@takluyver takluyver closed this May 10, 2017
@takluyver takluyver reopened this May 10, 2017
@takluyver
Copy link
Member

Wrong button...

@takluyver takluyver merged commit eef23cf into ipython:master May 10, 2017
@takluyver
Copy link
Member

@meeseeksdev backport

lumberbot-app bot pushed a commit that referenced this pull request May 10, 2017
@lukepfister lukepfister deleted the fix_mp_autoreload branch May 10, 2017 17:17
Carreau added a commit that referenced this pull request May 10, 2017
@Carreau Carreau added the backported PR that have been backported by MrMeeseeks label May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported PR that have been backported by MrMeeseeks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants