Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reload __mp_main__ #10523

Merged
merged 1 commit into from May 10, 2017
Merged

Don't reload __mp_main__ #10523

merged 1 commit into from May 10, 2017

Conversation

@lukepfister
Copy link
Contributor

lukepfister commented May 9, 2017

Fixes #10522.

Fixes #10522
@takluyver
Copy link
Member

takluyver commented May 10, 2017

I don't particularly understand why the previous attempt at a fix (#8568) didn't fix this, but this seems reasonable to me.

@takluyver takluyver requested a review from Carreau May 10, 2017
@Carreau
Copy link
Member

Carreau commented May 10, 2017

I don't think we really understand why, so I'm incline to merge as is.

5.x ?

@takluyver takluyver added this to the 5.4 milestone May 10, 2017
@takluyver
Copy link
Member

takluyver commented May 10, 2017

Yep, backporting to 5.x sounds reasonable.

@takluyver takluyver closed this May 10, 2017
@takluyver takluyver reopened this May 10, 2017
@takluyver
Copy link
Member

takluyver commented May 10, 2017

Wrong button...

@takluyver takluyver merged commit eef23cf into ipython:master May 10, 2017
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 0%)
Details
codecov/project 66.63% (+<.01%) compared to 30dced8
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@takluyver
Copy link
Member

takluyver commented May 10, 2017

@meeseeksdev backport

meeseeksdev bot pushed a commit that referenced this pull request May 10, 2017
Fixes  10522.
@lukepfister lukepfister deleted the lukepfister:fix_mp_autoreload branch May 10, 2017
Carreau added a commit that referenced this pull request May 10, 2017
Backport PR #10523 on branch 5.x
@Carreau Carreau added the backported label May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.