?? shall show docstring if source info is not available#10532
Merged
takluyver merged 1 commit intoipython:masterfrom May 11, 2017
Merged
?? shall show docstring if source info is not available#10532takluyver merged 1 commit intoipython:masterfrom
takluyver merged 1 commit intoipython:masterfrom
Conversation
Member
|
Seem reasonable to me. |
Carreau
approved these changes
May 11, 2017
Member
|
And to me :-) |
Member
|
Mind opening an issue to add a test? I'm on my phone.thanks!
…On May 11, 2017 09:45, "Thomas Kluyver" ***@***.***> wrote:
And to me :-)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#10532 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAUez7YWq9bSBnkte9kHjI6kXVYwZ9iwks5r4zs3gaJpZM4NYOHp>
.
|
Member
|
Sure, #10534 |
Member
|
Thanks ! Back on a keyboard ! I had already forgotten :-)
…On Thu, May 11, 2017 at 10:10 AM, Thomas Kluyver ***@***.***> wrote:
Sure, #10534 <#10534>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#10532 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAUez5Ke0HlA0ZnXS9HrPD1-kutlV_RZks5r40EJgaJpZM4NYOHp>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is to fix the issue #10531. the reason is that when there is no source info. detail_level > 0 shall still show docstring.