Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding snake case auto complete for #9420 #10537

Merged
merged 2 commits into from May 11, 2017
Merged

adding snake case auto complete for #9420 #10537

merged 2 commits into from May 11, 2017

Conversation

@sagnak
Copy link
Contributor

sagnak commented May 11, 2017

see #9420

@Carreau
Copy link
Member

Carreau commented May 11, 2017

Hi @sagnak , your git config email seem to not match your github set email, so you won't get the attributions for this commit.

Do you want to append the author ?

Also you can reference issues only be there numbers, and if you put them in the core of the commit message (that is not the first or second line) they will auto link on GitHub. Do you want to try to ammend your commit to fix this ?

@sagnak sagnak force-pushed the sagnak:master branch from 327aa0f to fa2b9b5 May 11, 2017
@sagnak sagnak force-pushed the sagnak:master branch from fa2b9b5 to 0999490 May 11, 2017
@sagnak
Copy link
Contributor Author

sagnak commented May 11, 2017

Hey, I fixed the commit history to reflect the username and email, but I do not follow where the core is, and what I should note there.

@takluyver
Copy link
Member

takluyver commented May 11, 2017

Links in the pull request title don't work, but you can easily link to an issue in the main description of a pull request by writing a number like this: #9420.

@Carreau Carreau changed the title adding snake case auto complete for https://github.com/ipython/ipytho… adding snake case auto complete for #9420 May 11, 2017
@Carreau Carreau added this to the 6.1 milestone May 11, 2017
@Carreau
Copy link
Member

Carreau commented May 11, 2017

Thanks ! Perfect !

@Carreau Carreau merged commit a422c40 into ipython:master May 11, 2017
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 0%)
Details
codecov/project 66.65% (+0.01%) compared to 4fa9620
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.