Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make variables shadow magics in autocompletion #10542

Merged
merged 1 commit into from May 12, 2017
Merged

Conversation

@evectant
Copy link
Contributor

evectant commented May 11, 2017

@Carreau Following up on #4877, please review.

@takluyver takluyver added this to the 6.1 milestone May 12, 2017
@takluyver
Copy link
Member

takluyver commented May 12, 2017

This looks good to me, thanks.

Do you want to drop a file into docs/source/whatsnew/pr with a brief description of this change for the release notes?

@evectant evectant force-pushed the evectant:issue-4877 branch from a9808a5 to 6019f47 May 12, 2017
@Carreau
Copy link
Member

Carreau commented May 12, 2017

Thanks !

@Carreau Carreau merged commit 12bf4d5 into ipython:master May 12, 2017
4 checks passed
4 checks passed
codecov/patch 92.85% of diff hit (target 0%)
Details
codecov/project 66.76% (+0.01%) compared to 4d6e8e5
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@evectant evectant deleted the evectant:issue-4877 branch May 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.