Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing arguments to modules with %run -m #10546

Merged
merged 1 commit into from May 14, 2017
Merged

Conversation

@jarrodj
Copy link
Contributor

jarrodj commented May 11, 2017

Hello, this is my first ipython pull request. I've made changes to the %run magic function to address issue #3664, and I added new tests.

@jarrodj jarrodj changed the title Fixes #3664 Allow passing arguments to modules with %run -m May 11, 2017
@jarrodj jarrodj force-pushed the jarrodj:master branch from aff4c02 to 239ab4c May 11, 2017
@Carreau Carreau added this to the 6.1 milestone May 14, 2017
@Carreau
Copy link
Member

Carreau commented May 14, 2017

Thanks @jarrodj ! Apologies for the delay in reviewing. It looks good to me.

Usually you can (if you wish) also drop a file in docs/source/whatsnew/pr that we merge together at release time to create the changelog but we can do that later.

Thanks !

@Carreau Carreau merged commit 9b305be into ipython:master May 14, 2017
4 checks passed
4 checks passed
codecov/patch 18.51% of diff hit (target 0%)
Details
codecov/project 66.58% (-0.05%) compared to 9e7fbf0
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.