Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Switch to simple `__IPYTHON__` global #1059

Merged
merged 3 commits into from

2 participants

Fernando Perez Min RK
Fernando Perez
Owner

In 0.11 we added __IPYTHON__active as a global, managed with the builtin trap, to try and detect nested ipythons. But in reality that mechanism is very fragile, the values aren't always right, and I think it's just unnecessary complexity. People do ask often, however, for some way of knowing whether they're running in ipython or not.

So this pr proposes that we simply create a global flag in __builtin__, called __IPYTHON__ (like the name we used to have and that it turns out people were already relying on). This flag will just be set to True at shell creation, with no attempt to delete it, or otherwise manage 'activity' (in event driven contexts this is a futile battle). I think this is the simplest thing we can do that will reasonable cover most cases without making promises we can't keep.

I'd like this merged before 0.12 so we're back to an api similar to what we had for most of our life from now on. I have the feeling that 0.12 will be when many people start really porting their codes forward, so minimizing api breakage here is worthwhile.

Min RK minrk commented on the diff
IPython/core/interactiveshell.py
@@ -573,6 +573,20 @@ class InteractiveShell(SingletonConfigurable, Magic):
self.magic_logstart()
def init_builtins(self):
+ # A single, static flag that we set to True. Its presence indicates
+ # that an IPython shell has been created, and we make no attempts at
+ # removing on exit or representing the existence of more than one
+ # IPython at a time.
+ builtin_mod.__dict__['__IPYTHON__'] = True
+
+ # In 0.11 we introduced '__IPYTHON__active' as an integer we'd try to
+ # manage on enter/exit, but with all our shells it's virtually
+ # impossible to get all the cases right. We're leaving the name in for
+ # those who adapted their codes to check for this flag, but will
+ # eventually remove it after a few more releases.
+ builtin_mod.__dict__['__IPYTHON__active'] = \
+ 'Deprecated, check for __IPYTHON__'
Min RK Owner
minrk added a note

I don't know if anyone was actually doing this, but if anyone was using this as the counter that it is, this will still break it. Do we want to worry about that?

Fernando Perez Owner
fperez added a note

Yes, I realize that. But I really doubt anyone was, given that even we were inconsistent in using it (the value isn't the same in kernels than it is in the terminal b/c our update logic was in the wrong place). So I think this is just an example of an api that didn't really work out, and which we might as well kill quickly rather than let it live further and possibly get entrenched when it shouldn't.

Min RK Owner
minrk added a note

Makes perfect sense, I just wanted to check (and have public record of the decision).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Min RK
Owner

This seems quite sensible, and seems ready for merge.

What are the official ways to:

a) determine that you are in an IPython interactive namespace (e.g. %run -i)
b) determine that you are in a process with IPython instance somewhere.

I've been checking for the existence of get_ipython for b), but I don't know about a). If I read correctly, __IPYTHON__ is also for b).

Fernando Perez
Owner

Yes, I guess part of the intent of this PR is for us to rationalize this... I'd say that __IPYTHON__ is for b), and I guess we don't really have anything special for a), because get_ipython gets injected into enough places that even a plain %run (without -i) will see it. Perhaps we should add another flag, say __IPYTHON__interactive for this, that would only be written to the user_ns when we prepare it? Kind of a mouthful, but if that sound like a good idea we can mull on the name.

Min RK
Owner

Since we have never had an answer for a), maybe we shouldn't be unnecessarily intrusive in the user_ns. If someone asks for it, then we can.

Fernando Perez
Owner

Great, that's a good plan. We'll then merge this only with __IPYTHON__, which should be sufficient and does simplify things out. Thanks for the review.

Fernando Perez fperez merged commit 487b6b9 into from
Fernando Perez fperez referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
28 IPython/core/builtin_trap.py
View
@@ -88,17 +88,12 @@ def add_builtin(self, key, value):
self._orig_builtins[key] = orig
bdict[key] = value
- def remove_builtin(self, key):
+ def remove_builtin(self, key, orig):
"""Remove an added builtin and re-set the original."""
- try:
- orig = self._orig_builtins.pop(key)
- except KeyError:
- pass
+ if orig is BuiltinUndefined:
+ del __builtin__.__dict__[key]
else:
- if orig is BuiltinUndefined:
- del __builtin__.__dict__[key]
- else:
- __builtin__.__dict__[key] = orig
+ __builtin__.__dict__[key] = orig
def activate(self):
"""Store ipython references in the __builtin__ namespace."""
@@ -107,22 +102,11 @@ def activate(self):
for name, func in self.auto_builtins.iteritems():
add_builtin(name, func)
- # Keep in the builtins a flag for when IPython is active. We set it
- # with setdefault so that multiple nested IPythons don't clobber one
- # another.
- __builtin__.__dict__.setdefault('__IPYTHON__active', 0)
-
def deactivate(self):
"""Remove any builtins which might have been added by add_builtins, or
restore overwritten ones to their previous values."""
- # Note: must iterate over a static keys() list because we'll be
- # mutating the dict itself
remove_builtin = self.remove_builtin
- for key in self._orig_builtins.keys():
- remove_builtin(key)
+ for key, val in self._orig_builtins.iteritems():
+ remove_builtin(key, val)
self._orig_builtins.clear()
self._builtins_added = False
- try:
- del __builtin__.__dict__['__IPYTHON__active']
- except KeyError:
- pass
14 IPython/core/interactiveshell.py
View
@@ -573,6 +573,20 @@ def init_logstart(self):
self.magic_logstart()
def init_builtins(self):
+ # A single, static flag that we set to True. Its presence indicates
+ # that an IPython shell has been created, and we make no attempts at
+ # removing on exit or representing the existence of more than one
+ # IPython at a time.
+ builtin_mod.__dict__['__IPYTHON__'] = True
+
+ # In 0.11 we introduced '__IPYTHON__active' as an integer we'd try to
+ # manage on enter/exit, but with all our shells it's virtually
+ # impossible to get all the cases right. We're leaving the name in for
+ # those who adapted their codes to check for this flag, but will
+ # eventually remove it after a few more releases.
+ builtin_mod.__dict__['__IPYTHON__active'] = \
+ 'Deprecated, check for __IPYTHON__'
Min RK Owner
minrk added a note

I don't know if anyone was actually doing this, but if anyone was using this as the counter that it is, this will still break it. Do we want to worry about that?

Fernando Perez Owner
fperez added a note

Yes, I realize that. But I really doubt anyone was, given that even we were inconsistent in using it (the value isn't the same in kernels than it is in the terminal b/c our update logic was in the wrong place). So I think this is just an example of an api that didn't really work out, and which we might as well kill quickly rather than let it live further and possibly get entrenched when it shouldn't.

Min RK Owner
minrk added a note

Makes perfect sense, I just wanted to check (and have public record of the decision).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
+
self.builtin_trap = BuiltinTrap(shell=self)
def init_inspector(self):
5 IPython/core/tests/test_interactiveshell.py
View
@@ -271,3 +271,8 @@ def test_1(self):
"""
cmd = ur'''python -c "'åäö'" '''
_ip.shell.system_raw(cmd)
+
+
+def test__IPYTHON__():
+ # This shouldn't raise a NameError, that's all
+ __IPYTHON__
6 IPython/frontend/terminal/interactiveshell.py
View
@@ -341,9 +341,6 @@ def interact(self, display_banner=None):
more = False
- # Mark activity in the builtins
- __builtin__.__dict__['__IPYTHON__active'] += 1
-
if self.has_readline:
self.readline_startup_hook(self.pre_readline)
hlen_b4_cell = self.readline.get_current_history_length()
@@ -413,9 +410,6 @@ def interact(self, display_banner=None):
hlen_b4_cell = \
self._replace_rlhist_multiline(source_raw, hlen_b4_cell)
- # We are off again...
- __builtin__.__dict__['__IPYTHON__active'] -= 1
-
# Turn off the exit flag, so the mainloop can be restarted if desired
self.exit_now = False
Something went wrong with that request. Please try again.