Give SyntaxError for naked return in timeit #10637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were missing invalid syntax because we put the code into a function before compiling it, leading to confusing error messages. Closes ipythongh-10636
|
@meeseeksdev backport |
|
Oops, something went wrong applying the patch... Please have a look at my logs. |
|
@meeseeksdev backport (just testing it will fail but should apply a needs manual backport label) |
|
There seem to be a conflict, please backport manually |
lumberbot-app
bot
added
the
Still Needs Manual Backport
Carreau
added a commit
to Carreau/ipython
that referenced
this pull request
Jul 20, 2017
Give SyntaxError for naked return in timeit
Carreau
added a commit
that referenced
this pull request
Jul 20, 2017
Backport PR #10637 on branch 5.x
Carreau
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were missing invalid syntax because we put the code into a function before compiling it, leading to confusing error messages.
Closes gh-10636