Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give SyntaxError for naked return in timeit #10637

Merged
merged 1 commit into from Jun 2, 2017
Merged

Conversation

@takluyver
Copy link
Member

@takluyver takluyver commented Jun 2, 2017

We were missing invalid syntax because we put the code into a function before compiling it, leading to confusing error messages.

Closes gh-10636

We were missing invalid syntax because we put the code into a function
before compiling it, leading to confusing error messages.

Closes gh-10636
@takluyver takluyver added this to the 5.5 milestone Jun 2, 2017
@Carreau Carreau merged commit 2065cc7 into ipython:master Jun 2, 2017
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 0%)
Details
codecov/project 66.9% (+<.01%) compared to 4883c32
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Carreau
Copy link
Member

@Carreau Carreau commented Jun 2, 2017

@meeseeksdev backport

@meeseeksdev
Copy link
Contributor

@meeseeksdev meeseeksdev bot commented Jun 2, 2017

Oops, something went wrong applying the patch... Please have a look at my logs.

@Carreau
Copy link
Member

@Carreau Carreau commented Jun 2, 2017

@meeseeksdev backport

(just testing it will fail but should apply a needs manual backport label)

@meeseeksdev
Copy link
Contributor

@meeseeksdev meeseeksdev bot commented Jun 2, 2017

There seem to be a conflict, please backport manually

Carreau added a commit to Carreau/ipython that referenced this pull request Jul 20, 2017
Give SyntaxError for naked return in timeit
Carreau added a commit that referenced this pull request Jul 20, 2017
Backport PR #10637 on branch 5.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.