As you type completer, fix on Firefox #1069

Merged
merged 1 commit into from Nov 30, 2011

Projects

None yet

3 participants

@Carreau
Member
Carreau commented Nov 30, 2011

As you type completer is (really) broken on firefox. It insert invisible characters

This should fixed the observed bugs and keep the same behavior across browser.

@Carreau Carreau as you type Completer, propagate event by hand
	Should fix completer behaviour on firefox...
40de69f
@takluyver
Member

Seems to be working here.

I've not used the notebook since we added the as-you-type completer - it's a brilliant tool. Thanks!

@Carreau
Member
Carreau commented Nov 30, 2011

Thanks,
I couldn't have done something like that, or even think of it without all the great work you all have done !
Maybe this 0.12 will finally convince some people I work with to consider other tool than matlab !

@fperez
Member
fperez commented Nov 30, 2011

Several people have confirmed this fixes it, merging. Thanks for the quick response, @Carreau!

@fperez fperez merged commit e89be0c into ipython:master Nov 30, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment