As you type completer, fix on Firefox #1069

Merged
merged 1 commit into from Nov 30, 2011

Conversation

Projects
None yet
3 participants
@Carreau
Member

Carreau commented Nov 30, 2011

As you type completer is (really) broken on firefox. It insert invisible characters

This should fixed the observed bugs and keep the same behavior across browser.

as you type Completer, propagate event by hand
	Should fix completer behaviour on firefox...
@takluyver

This comment has been minimized.

Show comment
Hide comment
@takluyver

takluyver Nov 30, 2011

Member

Seems to be working here.

I've not used the notebook since we added the as-you-type completer - it's a brilliant tool. Thanks!

Member

takluyver commented Nov 30, 2011

Seems to be working here.

I've not used the notebook since we added the as-you-type completer - it's a brilliant tool. Thanks!

@Carreau

This comment has been minimized.

Show comment
Hide comment
@Carreau

Carreau Nov 30, 2011

Member

Thanks,
I couldn't have done something like that, or even think of it without all the great work you all have done !
Maybe this 0.12 will finally convince some people I work with to consider other tool than matlab !

Member

Carreau commented Nov 30, 2011

Thanks,
I couldn't have done something like that, or even think of it without all the great work you all have done !
Maybe this 0.12 will finally convince some people I work with to consider other tool than matlab !

@fperez

This comment has been minimized.

Show comment
Hide comment
@fperez

fperez Nov 30, 2011

Member

Several people have confirmed this fixes it, merging. Thanks for the quick response, @Carreau!

Member

fperez commented Nov 30, 2011

Several people have confirmed this fixes it, merging. Thanks for the quick response, @Carreau!

fperez added a commit that referenced this pull request Nov 30, 2011

Merge pull request #1069 from Carreau/test-fix-ff-completer
Fix "As you type" tab completion for the notebook on firefox; recent merge had introduced a firefox-specific bug.

@fperez fperez merged commit e89be0c into ipython:master Nov 30, 2011

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

Merge pull request #1069 from Carreau/test-fix-ff-completer
Fix "As you type" tab completion for the notebook on firefox; recent merge had introduced a firefox-specific bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment