New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IPython work with OpenSSL in FIPS mode #10696

Merged
merged 1 commit into from Jul 13, 2017

Conversation

Projects
None yet
4 participants
@srinathgs
Contributor

srinathgs commented Jul 12, 2017

md5 is not supported with OpenSSL in FIPS mode, hence moving md5 to sha1

closes #10615

Make IPython work with OpenSSL in FIPS mode #10615
`md5` is not supported with OpenSSL in FIPS mode, hence moving `md5` to `sha1`

@minrk minrk changed the title from Make IPython work with OpenSSL in FIPS mode #10615 to Make IPython work with OpenSSL in FIPS mode Jul 12, 2017

@Carreau Carreau added this to the 5.5 milestone Jul 12, 2017

@Carreau

This comment has been minimized.

Show comment
Hide comment
@Carreau

Carreau Jul 12, 2017

Member

+1, I'll let it sit a bit just to get review and marked it as for backport. As soon as I'm back from holidaysI'll try to merge a couple of PR and make minor releases of IPython 5.x and 6.x

Thanks .

Member

Carreau commented Jul 12, 2017

+1, I'll let it sit a bit just to get review and marked it as for backport. As soon as I'm back from holidaysI'll try to merge a couple of PR and make minor releases of IPython 5.x and 6.x

Thanks .

@ivanov

ivanov approved these changes Jul 12, 2017

Thanks for getting back to this @srinathgs, glad to have your first contribution in IPython! Woo!

@takluyver takluyver merged commit bac5f14 into ipython:master Jul 13, 2017

4 checks passed

codecov/patch 100% of diff hit (target 0%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +33.03% compared to d2b29fb
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@takluyver

This comment has been minimized.

Show comment
Hide comment
@takluyver

takluyver Jul 13, 2017

Member

@meeseeksdev backport

Member

takluyver commented Jul 13, 2017

@meeseeksdev backport

meeseeksdev bot pushed a commit that referenced this pull request Jul 13, 2017

Backport PR #10696: Make IPython work with OpenSSL in FIPS mode
`md5` is not supported with OpenSSL in FIPS mode, hence moving `md5` to `sha1`

closes   10615

takluyver added a commit that referenced this pull request Jul 13, 2017

@Carreau Carreau added the backported label Jul 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment