Execution count after SyntaxError #1070

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@takluyver
Member

takluyver commented Nov 30, 2011

After a SyntaxError in code run by run_cell, only increment execution count where we would normally (i.e. if store_history is True).

Trivial change, but it's right in our core machinery, so I thought I'd let someone else have a quick look.

Closes gh-633

@fperez

This comment has been minimized.

Show comment
Hide comment
@fperez

fperez Nov 30, 2011

Member

Didn't last long without an open PR, heh? :) I'll have a look later today, thanks.

Member

fperez commented Nov 30, 2011

Didn't last long without an open PR, heh? :) I'll have a look later today, thanks.

@takluyver takluyver closed this in 762b0ea Dec 5, 2011

@minrk

This comment has been minimized.

Show comment
Hide comment
@minrk

minrk Dec 5, 2011

Member

Sensible, straightforward, merged.

Member

minrk commented Dec 5, 2011

Sensible, straightforward, merged.

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment