Execution count after SyntaxError #1070

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@takluyver
IPython member

After a SyntaxError in code run by run_cell, only increment execution count where we would normally (i.e. if store_history is True).

Trivial change, but it's right in our core machinery, so I thought I'd let someone else have a quick look.

Closes gh-633

@fperez
IPython member

Didn't last long without an open PR, heh? :) I'll have a look later today, thanks.

@takluyver takluyver added a commit that closed this pull request Dec 5, 2011
@takluyver takluyver After a SyntaxError in code run by run_cell, only increment execution…
… count where we would normally.

Closes gh-633
closes gh-1070
762b0ea
@takluyver takluyver closed this in 762b0ea Dec 5, 2011
@minrk
IPython member

Sensible, straightforward, merged.

@mattvonrocketstein mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
@takluyver takluyver After a SyntaxError in code run by run_cell, only increment execution…
… count where we would normally.

Closes gh-633
closes gh-1070
26c83b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment