Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.3 #10833

Merged
merged 6 commits into from Apr 2, 2018
Merged

Drop support for Python 3.3 #10833

merged 6 commits into from Apr 2, 2018

Conversation

@takluyver
Copy link
Member

@takluyver takluyver commented Sep 26, 2017

This makes 3.4 the minimum required version of Python. See discussion on #10161.

@takluyver takluyver added this to the 6.3 milestone Sep 26, 2017
raise ImportError(
"""
IPython 6.0+ does not support Python 2.6, 2.7, 3.0, 3.1, or 3.2.
IPython 6.3+ supports Python 3.4 and above.

This comment has been minimized.

This comment has been minimized.

@takluyver

takluyver Sep 26, 2017
Author Member

Thanks, updated.

@Carreau
Copy link
Member

@Carreau Carreau commented Sep 26, 2017

I'm Ok to drop 3.3 for 6.3; we just have to be careful, I don't think we've ever dropped a Python version a minor release though.

@willingc
Copy link
Member

@willingc willingc commented Sep 26, 2017

I think that we can provide guidance to pre-6.3 for anyone on Python 3.3.

@takluyver
Copy link
Member Author

@takluyver takluyver commented Sep 26, 2017

I'm also fine with leaving it until we split 6.x from master, and targetting it for 7.0. I don't think there's any hurry to do this - I don't know of anything we're eagerly waiting to do that's only possible from 3.4.

@Carreau
Copy link
Member

@Carreau Carreau commented Sep 26, 2017

I'm happy to wait a bit and see how much we are planning to keep the 6.x branch. We can fork master toward 7.0; though that might mean having a 5.x 6.x and master branch.

@takluyver
Copy link
Member Author

@takluyver takluyver commented Sep 26, 2017

I wouldn't start 7.0 for this; it's a simple set of changes, it's not worth having to backport everything for. Let's just let it sit until we have another breaking change that gives us a reason to aim for a 7.0 release.

@takluyver takluyver modified the milestones: 6.3, 7.0 Sep 26, 2017
@hugovk
hugovk approved these changes Oct 2, 2017
@jzf2101
Copy link
Contributor

@jzf2101 jzf2101 commented Nov 20, 2017

See #10911 for PR related to changing testing for 3.3. with docs

@takluyver
Copy link
Member Author

@takluyver takluyver commented Nov 20, 2017

I think it's fine to stop testing with 3.3 in 6.x releases, and then make the changes that we know will break it for 7.0.

@Carreau
Copy link
Member

@Carreau Carreau commented Nov 21, 2017

I think it's fine to stop testing with 3.3 in 6.x releases, and then make the changes that we know will break it for 7.0.

Ok, fair enough. This need rebase now. I think a nov/dec release would be welcome. Do we wait for Dec25 ?

@takluyver takluyver force-pushed the takluyver:req-py34 branch from 2daded9 to c731308 Apr 2, 2018
@takluyver
Copy link
Member Author

@takluyver takluyver commented Apr 2, 2018

I've rebased the changes and updated the version numbers in various docs and messages to say that 7.0 (not 6.3) drops support for Python 3.3.

@Carreau
Copy link
Member

@Carreau Carreau commented Apr 2, 2018

@takluyver do you want to merge this, so that we start master being a 7.0-dev ?

@Carreau
Carreau approved these changes Apr 2, 2018
@takluyver
Copy link
Member Author

@takluyver takluyver commented Apr 2, 2018

That's my plan. I've already updated the version number in master.

@Carreau
Carreau approved these changes Apr 2, 2018
@Carreau Carreau merged commit dda5238 into ipython:master Apr 2, 2018
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 0%)
Details
codecov/project Absolute coverage decreased by -0.05% but relative coverage increased by +32.72% compared to 952d566
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants