New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Python 3.3 #10833
Drop support for Python 3.3 #10833
Conversation
IPython/__init__.py
Outdated
raise ImportError( | ||
""" | ||
IPython 6.0+ does not support Python 2.6, 2.7, 3.0, 3.1, or 3.2. | ||
IPython 6.3+ supports Python 3.4 and above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's some similar text to update in setup.py
https://github.com/takluyver/ipython/blob/68559994a2c1efcbd408fa63adaf1867389e22df/setup.py#L47
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, updated.
I'm Ok to drop 3.3 for 6.3; we just have to be careful, I don't think we've ever dropped a Python version a minor release though. |
I think that we can provide guidance to pre-6.3 for anyone on Python 3.3. |
I'm also fine with leaving it until we split 6.x from master, and targetting it for 7.0. I don't think there's any hurry to do this - I don't know of anything we're eagerly waiting to do that's only possible from 3.4. |
I'm happy to wait a bit and see how much we are planning to keep the 6.x branch. We can fork master toward 7.0; though that might mean having a 5.x 6.x and master branch. |
I wouldn't start 7.0 for this; it's a simple set of changes, it's not worth having to backport everything for. Let's just let it sit until we have another breaking change that gives us a reason to aim for a 7.0 release. |
See #10911 for PR related to changing testing for 3.3. with docs |
I think it's fine to stop testing with 3.3 in 6.x releases, and then make the changes that we know will break it for 7.0. |
Ok, fair enough. This need rebase now. I think a nov/dec release would be welcome. Do we wait for Dec25 ? |
I've rebased the changes and updated the version numbers in various docs and messages to say that 7.0 (not 6.3) drops support for Python 3.3. |
@takluyver do you want to merge this, so that we start master being a 7.0-dev ? |
That's my plan. I've already updated the version number in master. |
This makes 3.4 the minimum required version of Python. See discussion on #10161.