Don't list pygments styles on import #10859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Listing pygments styles forces pygments to load plugins, which slows startup and may cause unexpected errors from other packages. Closes jupyter/notebook#2926
|
With this change, I see a reduction in cold-start time from ~11 seconds to ~6 seconds (this is on a spinning metal hard drive), and a reduction in warm start from ~1.1s to ~0.9s. |
|
I'll merge this tomorrow unless someone says otherwise. |
takluyver
added a commit
that referenced
this pull request
Oct 20, 2017
Backport PR #10859 on branch 5.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listing the styles forces pygments to load plugins, which slows startup and may cause unexpected errors from other packages. We shouldn't be calling this on import.
The list of available styles will also depend on what packages are installed, so building our config docs with one list may be misleading. I've made the help string point to
pygmentize -L stylesto see available styles on your system.Closes jupyter/notebook#2926