Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap the check for Jedi versions around #10956

Merged
merged 1 commit into from Jan 3, 2018

Conversation

@takluyver
Copy link
Member

@takluyver takluyver commented Dec 20, 2017

It's possible to have Parso installed alongside an older version of Jedi which doesn't use it. I had this situation, and it was messing up my tab completions because it couldn't detect when it was in a string.

Jedi 0.11 doesn't have the jedi.parser subpackage, so I think checking it this way should be more reliable.

@takluyver takluyver added this to the 6.3 milestone Dec 20, 2017
@takluyver takluyver requested a review from Carreau Dec 20, 2017
@minrk
minrk approved these changes Jan 2, 2018
@Carreau Carreau merged commit c739659 into ipython:master Jan 3, 2018
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 0%)
Details
codecov/project 67.27% (+<.01%) compared to 38e0033
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Carreau
Copy link
Member

@Carreau Carreau commented Jan 3, 2018

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.