New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change defaults to be consistent with original defaults and REPL perf… #10999

Merged
merged 1 commit into from Feb 12, 2018

Conversation

Projects
None yet
2 participants
@cottrell
Contributor

cottrell commented Feb 4, 2018

Happy to hear feedback on why whatever is currently going on is better but seems like generally it is best to not dramatically change the defaults. . is one of the most important operations in python (IPython) from a human perspective so everyone is quite sensitive about this stuff.

Case-insensitivity break tab-completion in the case when there is one case-sensitive choice but several case-insensitive choices. Would be interesting to consider second to be case insensitive or something like that. Then you don't break that UX on the first tab completion.

…ormance. #10728 #10988

@takluyver

This comment has been minimized.

Member

takluyver commented Feb 5, 2018

I'm happy with the bit setting jedi to do case-sensitive completion, but I'd rather leave the default presentation as 'multicolumn'.

cc @Carreau

@cottrell

This comment has been minimized.

Contributor

cottrell commented Feb 10, 2018

K, I've just done the case-sensitive one-line change.

@takluyver takluyver added this to the 6.3 milestone Feb 12, 2018

@takluyver

This comment has been minimized.

Member

takluyver commented Feb 12, 2018

Thanks, merging. We may want to refine this further (e.g. falling back to case-insensitive search when we find no matches), but it sounds like this will be an improvement for most users.

That's always a dangerous thing to say. If there are people who don't like this change, they won't be complaining yet. 🤞 Fingers crossed...

@takluyver takluyver merged commit 0a72f2f into ipython:master Feb 12, 2018

4 checks passed

codecov/patch 100% of diff hit (target 0%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +32.76% compared to db2a0da
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cottrell

This comment has been minimized.

Contributor

cottrell commented Feb 12, 2018

Ah, yes falling back in the case of no-matches ... I will try to remember to have a look if it is quick to do. This functionality could actually save me time when teaching people new things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment