Change defaults to be consistent with original defaults and REPL perf… #10999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm happy with the bit setting jedi to do case-sensitive completion, but I'd rather leave the default presentation as 'multicolumn'. cc @Carreau |
|
K, I've just done the case-sensitive one-line change. |
|
Thanks, merging. We may want to refine this further (e.g. falling back to case-insensitive search when we find no matches), but it sounds like this will be an improvement for most users. That's always a dangerous thing to say. If there are people who don't like this change, they won't be complaining yet. 🤞 Fingers crossed... |
|
Ah, yes falling back in the case of no-matches ... I will try to remember to have a look if it is quick to do. This functionality could actually save me time when teaching people new things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happy to hear feedback on why whatever is currently going on is better but seems like generally it is best to not dramatically change the defaults. . is one of the most important operations in python (IPython) from a human perspective so everyone is quite sensitive about this stuff.
Case-insensitivity break tab-completion in the case when there is one case-sensitive choice but several case-insensitive choices. Would be interesting to consider second to be case insensitive or something like that. Then you don't break that UX on the first tab completion.
…ormance. #10728 #10988