workaround spawnb missing from pexpect.__all__ #1101

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@minrk
Member

minrk commented Dec 4, 2011

@takluyver's pexpect-u is unicode-ready, and we handle it, but
spawnb is not in __all__ (at least in the 2.5 release), so our
check for it here
fails, and we use the unicode output, calling decode on it directly,
which would raise UnicodeError on things like ls in a dir with unicode files.

This manually assigns pexpect.spawnb, not trusting that it will be included in
from pexpect import *.

workaround spawnb missing from pexpect.__all__
@takluyver's pexpect-u is unicode-ready, and we handle it, but
spawnb is not in `__all__` (at least in the 2.5 release), so our
check for it [here](https://github.com/ipython/ipython/blob/master/IPython/utils/_process_posix.py#L151)
fails, and we use the unicode output, calling `decode` on it directly,
which would raise UnicodeError on things like `ls` in a dir with unicode files.

This manually assigns `pexpect.spawnb`, not trusting that it will be included in
`from pexpect import *`.
@takluyver

This comment has been minimized.

Show comment
Hide comment
@takluyver

takluyver Dec 4, 2011

Member

Since there's probably no-one using pexpect-u yet, would it make more sense to just add spawnb to __all__, and then release the corresponding version as 2.5.1?

Member

takluyver commented Dec 4, 2011

Since there's probably no-one using pexpect-u yet, would it make more sense to just add spawnb to __all__, and then release the corresponding version as 2.5.1?

@minrk

This comment has been minimized.

Show comment
Hide comment
@minrk

minrk Dec 4, 2011

Member

Sure.

-MinRK

On Dec 4, 2011, at 15:20, Thomasreply@reply.github.com wrote:

Since there's probably no-one using pexpect-u yet, would it make more sense to just add spawnb to __all__, and then release the corresponding version as 2.5.1?


Reply to this email directly or view it on GitHub:
#1101 (comment)

Member

minrk commented Dec 4, 2011

Sure.

-MinRK

On Dec 4, 2011, at 15:20, Thomasreply@reply.github.com wrote:

Since there's probably no-one using pexpect-u yet, would it make more sense to just add spawnb to __all__, and then release the corresponding version as 2.5.1?


Reply to this email directly or view it on GitHub:
#1101 (comment)

@takluyver

This comment has been minimized.

Show comment
Hide comment
@takluyver

takluyver Dec 4, 2011

Member

OK, I'll try to get round to it, but it might be a couple of days.

Member

takluyver commented Dec 4, 2011

OK, I'll try to get round to it, but it might be a couple of days.

@minrk

This comment has been minimized.

Show comment
Hide comment
@minrk

minrk Dec 5, 2011

Member

That's fine. I'll just close this, noting that IPython requires pexpect-u ≥ 2.5.1.

Member

minrk commented Dec 5, 2011

That's fine. I'll just close this, noting that IPython requires pexpect-u ≥ 2.5.1.

@minrk minrk closed this Dec 5, 2011

@takluyver

This comment has been minimized.

Show comment
Hide comment
@takluyver

takluyver Dec 10, 2011

Member

Released pexpect 2.5.1, equivalent to the version we bundle in IPython.

Member

takluyver commented Dec 10, 2011

Released pexpect 2.5.1, equivalent to the version we bundle in IPython.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment