New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check for being inside string for jedi completions #11035

Merged
merged 1 commit into from Mar 29, 2018

Conversation

Projects
None yet
1 participant
@takluyver
Member

takluyver commented Mar 7, 2018

Completing something like a = "/home/<tab> gives a token "/home" starting with a space, which wasn't being caught.

Closes gh-11032

@Carreau do you think you'll have time soon to get back to working on the jedi integration? I like the idea, but it seems to be making the user experience worse and the code feels hackish (we're using a private method to access Jedi's parse tree to decide when to ignore its suggestions entirely). If we can't commit to making it work well, I think we should drop it and go back to relying on the battle-tested IPython completion machinery.

@takluyver takluyver added this to the 6.3 milestone Mar 7, 2018

@takluyver

This comment has been minimized.

Member

takluyver commented Mar 13, 2018

Ping @Carreau - do you want to look at this before I merge it?

@takluyver takluyver merged commit f26efbe into ipython:master Mar 29, 2018

4 checks passed

codecov/patch 100% of diff hit (target 0%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +32.73% compared to dc46d30
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@takluyver takluyver deleted the takluyver:i11032 branch Mar 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment