Fix check for being inside string for jedi completions#11035
Merged
takluyver merged 1 commit intoipython:masterfrom Mar 29, 2018
Merged
Fix check for being inside string for jedi completions#11035takluyver merged 1 commit intoipython:masterfrom
takluyver merged 1 commit intoipython:masterfrom
Conversation
Member
Author
|
Ping @Carreau - do you want to look at this before I merge it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completing something like
a = "/home/<tab>gives a token"/home"starting with a space, which wasn't being caught.Closes gh-11032
@Carreau do you think you'll have time soon to get back to working on the jedi integration? I like the idea, but it seems to be making the user experience worse and the code feels hackish (we're using a private method to access Jedi's parse tree to decide when to ignore its suggestions entirely). If we can't commit to making it work well, I think we should drop it and go back to relying on the battle-tested IPython completion machinery.