Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shell.check_complete() method #11044

Merged
merged 1 commit into from Mar 13, 2018
Merged

Conversation

@takluyver
Copy link
Member

@takluyver takluyver commented Mar 12, 2018

This method is also added by #11041 for 7.0. This PR proposes adding the same method to 5.x and 6.x, to make it easier to switch ipykernel over to this instead of shell.input_splitter.check_complete().

@takluyver takluyver added this to the 5.6 milestone Mar 12, 2018
@minrk minrk merged commit 3785286 into ipython:master Mar 13, 2018
4 checks passed
4 checks passed
codecov/patch 33.33% of diff hit (target 0%)
Details
codecov/project 67.25% (-0.01%) compared to dc46d30
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
meeseeksdev bot pushed a commit that referenced this pull request Mar 13, 2018
takluyver added a commit that referenced this pull request Mar 13, 2018
Backport PR #11044 on branch 5.x
@takluyver takluyver deleted the takluyver:check_complete-method branch Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants