Get jedi completions on only text before the cursor #11063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes ipythongh-10781 This might make completions less smart in some situations, if Jedi can do intelligent things with the text after the cursor, but it fixes an important case that has been causing annoyances.
|
+1 as a workaround, but we should have a proper fix at some point. |
|
I agree. I put some ideas about how to do this check more robustly in #11064. |
|
Thanks! This was the last thing open for 6.3. Is there anything else you can see that should happen before a release? If not, I'll try to get 6.3 and 5.5 out tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-10781
This might make completions less smart in some situations, if Jedi can do intelligent things with the text after the cursor, but it fixes an important case that has been causing annoyances.