New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get jedi completions on only text before the cursor #11063

Merged
merged 1 commit into from Apr 1, 2018

Conversation

Projects
None yet
2 participants
@takluyver
Member

takluyver commented Mar 31, 2018

Closes gh-10781

This might make completions less smart in some situations, if Jedi can do intelligent things with the text after the cursor, but it fixes an important case that has been causing annoyances.

Get jedi completions on only text before the cursor
Closes gh-10781

This might make completions less smart in some situations, if Jedi can
do intelligent things with the text after the cursor, but it fixes an
important case that has been causing annoyances.

@takluyver takluyver added this to the 6.3 milestone Mar 31, 2018

@takluyver takluyver requested a review from Carreau Mar 31, 2018

@Carreau

This comment has been minimized.

Member

Carreau commented Apr 1, 2018

+1 as a workaround, but we should have a proper fix at some point.

@takluyver

This comment has been minimized.

Member

takluyver commented Apr 1, 2018

I agree. I put some ideas about how to do this check more robustly in #11064.

@Carreau Carreau merged commit 25a9c9d into ipython:master Apr 1, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 65778ad...f569b76
Details
codecov/project 67.26% (-0.01%) compared to 65778ad
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@takluyver takluyver deleted the takluyver:i10781 branch Apr 1, 2018

@takluyver

This comment has been minimized.

Member

takluyver commented Apr 1, 2018

Thanks! This was the last thing open for 6.3. Is there anything else you can see that should happen before a release? If not, I'll try to get 6.3 and 5.5 out tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment