Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upGet jedi completions on only text before the cursor #11063
Conversation
takluyver
added this to the 6.3 milestone
Mar 31, 2018
takluyver
requested a review
from
Carreau
Mar 31, 2018
takluyver
referenced this pull request
Mar 31, 2018
Closed
Detect string completion when no syntax error #10996
This comment has been minimized.
This comment has been minimized.
|
+1 as a workaround, but we should have a proper fix at some point. |
This comment has been minimized.
This comment has been minimized.
|
I agree. I put some ideas about how to do this check more robustly in #11064. |
Carreau
merged commit 25a9c9d
into
ipython:master
Apr 1, 2018
takluyver
deleted the
takluyver:i10781
branch
Apr 1, 2018
This comment has been minimized.
This comment has been minimized.
|
Thanks! This was the last thing open for 6.3. Is there anything else you can see that should happen before a release? If not, I'll try to get 6.3 and 5.5 out tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
takluyver commentedMar 31, 2018
Closes gh-10781
This might make completions less smart in some situations, if Jedi can do intelligent things with the text after the cursor, but it fixes an important case that has been causing annoyances.