Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow offset 0 in position_to_cursor #11065

Merged
merged 1 commit into from Apr 2, 2018
Merged

Allow offset 0 in position_to_cursor #11065

merged 1 commit into from Apr 2, 2018

Conversation

@takluyver
Copy link
Member

@takluyver takluyver commented Apr 2, 2018

Closes gh-11029

Closes gh-11029
@takluyver
Copy link
Member Author

@takluyver takluyver commented Apr 2, 2018

Merging this because I'm trying to make a release, and it seems harmless (famous last words)

@takluyver takluyver merged commit caf2608 into ipython:master Apr 2, 2018
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 0%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +32.72% compared to 25a9c9d
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@takluyver takluyver deleted the takluyver:i11029 branch Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.