New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added fix for display hook call output format #11101
Conversation
Failure seems unrelated to PR? |
That might be due to a recent release of Jedi. I'll investigate. |
@Carreau Any update on this? |
I think this makes sense. The corresponding change to displaypub was in #10837, which shipped in 6.3. Reopening to rerun tests. |
...which probably won't help, because they're failing on master as well. @Carreau , did you get anywhere with the |
Looks like the tests are passing now against the master changes |
Yes we've commented the tests. I'm flabbergasted our bot did not react to the PR merge. I guess we also need to backport that on 6.x. and do a 5.x, and 6.x release. |
There seem to be a conflict, please backport manually |
Ah, no my bad, I merged the backport, and not on master that's why. |
Backport PR #11101 on branch 6.x
Hit an issue were under complex conditions, that are hard to express in a simple notebook, the displayhook was building output array elements in the old tuple format instead of the kwarg format. This causes (ignore py2 package path in the stack trace example):
Tracing down the fix was to adjust the callable which was not updated. Tracing the capture code throughout the project was a real headache as the global state is touched a lot along the way, so I made a spec just to prove that the output format conforms rather than express where that hook callable is made consequentially.
Py2 backport PR: #11102