Skip to content
This repository

Fixing #1112 removing failing asserts for test_carriage_return and test_... #1113

Closed
wants to merge 1 commit into from

2 participants

Jörgen Stenarson Min RK
Jörgen Stenarson
Collaborator

...beep.

The failing asserts were checking the count property of the Action
tuple objects there is no count field in these Action tuples so
the count method of the regular tuple class is resolved.

Fixing #1112 removing failing asserts for test_carriage_return and te…
…st_beep.

The failing asserts were checking the count property of the Action
tuple objects there is no count field in these Action tuples so
the count method of the regular tuple class is resolved.
8c6d953
Min RK
Owner

This is correct - the count need never have been checked, the simple presence of the action satisfies the test.

Thanks!

Min RK minrk closed this pull request from a commit December 07, 2011
Fixing #1112 removing failing asserts for test_carriage_return and te…
…st_beep.

The failing asserts were checking the count property of the Action
tuple objects there is no count field in these Action tuples so
the count method of the regular tuple class is resolved.

closes #1112
closes #1113
bdcfcc6
Min RK minrk closed this in bdcfcc6 December 07, 2011
Brian E. Granger ellisonbg referenced this pull request from a commit January 10, 2012
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Dec 07, 2011
Fixing #1112 removing failing asserts for test_carriage_return and te…
…st_beep.

The failing asserts were checking the count property of the Action
tuple objects there is no count field in these Action tuples so
the count method of the regular tuple class is resolved.
8c6d953
This page is out of date. Refresh to see the latest.
2  IPython/frontend/qt/console/tests/test_ansi_code_processor.py
@@ -110,7 +110,6 @@ def test_carriage_return(self):
110 110
         self.assertEquals(len(self.processor.actions), 1)
111 111
         action = self.processor.actions[0]
112 112
         self.assertEquals(action.action, 'carriage-return')
113  
-        self.assertEquals(action.count, 1)
114 113
 
115 114
     def test_beep(self):
116 115
         """ Are beep characters processed correctly?
@@ -120,7 +119,6 @@ def test_beep(self):
120 119
         self.assertEquals(len(self.processor.actions), 1)
121 120
         action = self.processor.actions[0]
122 121
         self.assertEquals(action.action, 'beep')
123  
-        self.assertEquals(action.count, 1)
124 122
 
125 123
 
126 124
 if __name__ == '__main__':
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.