Skip to content

Loading…

Fixing #1112 removing failing asserts for test_carriage_return and test_... #1113

Closed
wants to merge 1 commit into from

2 participants

@jstenar
IPython member

...beep.

The failing asserts were checking the count property of the Action
tuple objects there is no count field in these Action tuples so
the count method of the regular tuple class is resolved.

J�rgen Stenarson Fixing #1112 removing failing asserts for test_carriage_return and te…
…st_beep.

The failing asserts were checking the count property of the Action
tuple objects there is no count field in these Action tuples so
the count method of the regular tuple class is resolved.
8c6d953
@minrk
IPython member

This is correct - the count need never have been checked, the simple presence of the action satisfies the test.

Thanks!

@minrk minrk added a commit that closed this pull request
Jörgen Stenarson Fixing #1112 removing failing asserts for test_carriage_return and te…
…st_beep.

The failing asserts were checking the count property of the Action
tuple objects there is no count field in these Action tuples so
the count method of the regular tuple class is resolved.

closes #1112
closes #1113
bdcfcc6
@minrk minrk closed this in bdcfcc6
@mattvonrocketstein mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request
Jörgen Stenarson Fixing #1112 removing failing asserts for test_carriage_return and te…
…st_beep.

The failing asserts were checking the count property of the Action
tuple objects there is no count field in these Action tuples so
the count method of the regular tuple class is resolved.

closes #1112
closes #1113
ab2908b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 7, 2011
  1. Fixing #1112 removing failing asserts for test_carriage_return and te…

    J�rgen Stenarson committed
    …st_beep.
    
    The failing asserts were checking the count property of the Action
    tuple objects there is no count field in these Action tuples so
    the count method of the regular tuple class is resolved.
Showing with 0 additions and 2 deletions.
  1. +0 −2 IPython/frontend/qt/console/tests/test_ansi_code_processor.py
View
2 IPython/frontend/qt/console/tests/test_ansi_code_processor.py
@@ -110,7 +110,6 @@ def test_carriage_return(self):
self.assertEquals(len(self.processor.actions), 1)
action = self.processor.actions[0]
self.assertEquals(action.action, 'carriage-return')
- self.assertEquals(action.count, 1)
def test_beep(self):
""" Are beep characters processed correctly?
@@ -120,7 +119,6 @@ def test_beep(self):
self.assertEquals(len(self.processor.actions), 1)
action = self.processor.actions[0]
self.assertEquals(action.action, 'beep')
- self.assertEquals(action.count, 1)
if __name__ == '__main__':
Something went wrong with that request. Please try again.