Fixing #1112 removing failing asserts for test_carriage_return and test_... #1113

Closed
wants to merge 1 commit into
from

2 participants

@jstenar
IPython member

...beep.

The failing asserts were checking the count property of the Action
tuple objects there is no count field in these Action tuples so
the count method of the regular tuple class is resolved.

Jörgen Stenarson Fixing #1112 removing failing asserts for test_carriage_return and te…
…st_beep.

The failing asserts were checking the count property of the Action
tuple objects there is no count field in these Action tuples so
the count method of the regular tuple class is resolved.
8c6d953
@minrk
IPython member

This is correct - the count need never have been checked, the simple presence of the action satisfies the test.

Thanks!

@minrk minrk added a commit that closed this pull request Dec 7, 2011
Jörgen Stenarson Fixing #1112 removing failing asserts for test_carriage_return and te…
…st_beep.

The failing asserts were checking the count property of the Action
tuple objects there is no count field in these Action tuples so
the count method of the regular tuple class is resolved.

closes #1112
closes #1113
bdcfcc6
@minrk minrk closed this in bdcfcc6 Dec 7, 2011
@mattvonrocketstein mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Jörgen Stenarson Fixing #1112 removing failing asserts for test_carriage_return and te…
…st_beep.

The failing asserts were checking the count property of the Action
tuple objects there is no count field in these Action tuples so
the count method of the regular tuple class is resolved.

closes #1112
closes #1113
ab2908b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment