signature: use inspect instead of type checks #11139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdemeyer
changed the title
|
+1. Do you think it is worth backporting to 5.x (Python 2.7), or can this be a carrot for 3.x users ? |
|
It's a pull request to the |
|
Oh, sorry, I missread. Thanks. |
|
@jdemeyer released on PyPI, I'll update the conda recipe later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
inspect.isfunctionis more future-compatible in case that the implementation ofinspect.isfunctionever changes.In SageMath, we actually monkey-patch
inspect.isfunctionto allow for Cython functions. So while this patch doesn't change anything at all in vanilla Python, it is important for Cython support.More context: