Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #11082 - use dpaste.com, also remove py2 compatibility imports #11182

Merged
merged 1 commit into from Jun 10, 2018

Conversation

@spookyvision
Copy link
Contributor

@spookyvision spookyvision commented Jun 9, 2018

No description provided.

@takluyver
Copy link
Member

@takluyver takluyver commented Jun 10, 2018

Thanks! I assume you've tested this locally?

You neatly got the PR number 100 greater than the issue you're fixing.

@spookyvision
Copy link
Contributor Author

@spookyvision spookyvision commented Jun 10, 2018

yup, I did do some tests, including output containing utf-8:
http://dpaste.com/0A3XY3N

@spookyvision
Copy link
Contributor Author

@spookyvision spookyvision commented Jun 10, 2018

oops, wrong button I guess

@takluyver takluyver added this to the 6.5 milestone Jun 10, 2018
@takluyver takluyver merged commit a7de851 into ipython:master Jun 10, 2018
4 checks passed
4 checks passed
@codecov
codecov/patch 40% of diff hit (target 0%)
Details
@codecov
codecov/project 67.23% (+0.01%) compared to e779fc5
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@takluyver
Copy link
Member

@takluyver takluyver commented Jun 10, 2018

Thanks!

meeseeksdev bot pushed a commit that referenced this pull request Jun 10, 2018
takluyver added a commit that referenced this pull request Jun 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants