updated vim-ipython (pending) #1120

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@ivanov
Member
ivanov commented Dec 7, 2011

Just wanted to place this in the queue to make sure that an updated version goes into 0.12

I wanted to add this but not have it merged until 0.12 RCs are being cut, but in case I don't get to it again, this version is a big improvement over what ships with ipython currently.

@ivanov ivanov updated vim-ipython
ivanov/vim-ipython 3b62ca30c4cd3912532855279cdd161d2ef3c640
2ffa8c9
@fperez
Member
fperez commented Dec 13, 2011

Does this need any further updates, or should we just merge it as-is? I think we're about ready to cut the first RC in a day or two.

@fperez
Member
fperez commented Dec 13, 2011

@ivanov: last call... Do you want us to wait on this one for further updates, or should we go ahead and merge? I'd like to get to the RC pretty soon...

@ivanov
Member
ivanov commented Dec 13, 2011

sorry, I've been a bit occupied - please merge as is

@fperez
Member
fperez commented Dec 14, 2011

Was it you taking the pic or holding the sign?

@ivanov ivanov added a commit that closed this pull request Dec 14, 2011
@ivanov ivanov updated vim-ipython
Various small updates to vim integration.

Closes #1120, rebased to avoid unnecessary recursive merge.
633cbe1
@ivanov ivanov closed this in 633cbe1 Dec 14, 2011
@fperez
Member
fperez commented Dec 14, 2011

OK, merged and pushed. Thanks!

@ivanov
Member
ivanov commented Dec 14, 2011

It was me holding the sign - I know it's not PEP-8 compliant - I'll pylint and pyflakes and otherwise PEP8-proof my future political activity.

@fperez
Member
fperez commented Dec 14, 2011

Otherwise we won't commit! :)

@mattvonrocketstein mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
@ivanov ivanov updated vim-ipython
Various small updates to vim integration.

Closes #1120, rebased to avoid unnecessary recursive merge.
4555384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment