Python 3.7 autocomplete bugfix #11227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a bug in try_import that will cause this test to raise an "NoneType has no attribute" exception.
yen223
force-pushed
the
11226-3-7-autocomplete-bugfix
branch
3 times, most recently
from
3a9ee7e
to
fd8dc7a
Compare
yen223
force-pushed
the
11226-3-7-autocomplete-bugfix
branch
from
fd8dc7a
to
88a6a54
Compare
| """ | ||
| fake_module_name = "foo" | ||
| with TemporaryDirectory() as tmpdir: | ||
| sys.path.insert(0, tmpdir) |
There was a problem hiding this comment.
Don't forget to remove tmpdir from sys.path at the end. See test_bad_module_all for example.
|
this and #11179 would be nice to have soon in a 6.5 update release. |
|
Thanks, i'll backport that to the 6.x branch, and try to do a release soon. |
Carreau
added a commit
to meeseeksmachine/ipython
that referenced
this pull request
Jul 23, 2018
Carreau
added a commit
that referenced
this pull request
Jul 23, 2018
…227-on-6.x Backport PR #11227 on branch 6.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11226