Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.7 autocomplete bugfix #11227

Merged
merged 3 commits into from Jul 22, 2018

Conversation

Projects
None yet
4 participants
@yen223
Copy link
Contributor

yen223 commented Jul 14, 2018

Resolves #11226

Add regression test
There's a bug in try_import that will cause this test to raise an
"NoneType has no attribute" exception.

@yen223 yen223 changed the title 11226 3 7 autocomplete bugfix Python 3.7 autocomplete bugfix Jul 14, 2018

@yen223 yen223 force-pushed the yen223:11226-3-7-autocomplete-bugfix branch 3 times, most recently from 3a9ee7e to fd8dc7a Jul 14, 2018

@yen223 yen223 force-pushed the yen223:11226-3-7-autocomplete-bugfix branch from fd8dc7a to 88a6a54 Jul 14, 2018

"""
fake_module_name = "foo"
with TemporaryDirectory() as tmpdir:
sys.path.insert(0, tmpdir)

This comment has been minimized.

@serhiy-storchaka

serhiy-storchaka Jul 14, 2018

Don't forget to remove tmpdir from sys.path at the end. See test_bad_module_all for example.

This comment has been minimized.

@yen223

yen223 Jul 14, 2018

Author Contributor

Done

@stonebig

This comment has been minimized.

Copy link
Contributor

stonebig commented Jul 22, 2018

this and #11179 would be nice to have soon in a 6.5 update release.

@Carreau Carreau added this to the 6.5 milestone Jul 22, 2018

@Carreau Carreau merged commit 134f970 into ipython:master Jul 22, 2018

4 checks passed

codecov/patch 100% of diff hit (target 0%)
Details
codecov/project 67.29% (+<.01%) compared to 652a8fe
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

meeseeksdev bot pushed a commit that referenced this pull request Jul 22, 2018

@Carreau

This comment has been minimized.

Copy link
Member

Carreau commented Jul 22, 2018

Thanks, i'll backport that to the 6.x branch, and try to do a release soon.
Apologies for the delay.

Carreau added a commit to meeseeksmachine/ipython that referenced this pull request Jul 23, 2018

Carreau added a commit that referenced this pull request Jul 23, 2018

@yen223 yen223 deleted the yen223:11226-3-7-autocomplete-bugfix branch Jul 25, 2018

@Carreau Carreau added the backported label Jul 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.