Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
notebook : update logo #1125
With the logo as an image the font is not used ... do you want to make it default in some other place of the notebook ? remove it ? Are you against linking the font to google web-font ? We can redistribute it in the static folder.
Nice, though I would remove the 'interactive computing' subheading, which forces the text to be too small.
Also, I would remove the font-related changes, especially the unused webfont. There's no text in the header, so loading a webfont gets us nothing but extra traffic, and a failed request in offline mode, unless I am mistaken.
Hm, Image + text may not be a good idea, despite the fact that it does make it nice and easy to change. I'm not particularly fond of shipping fonts, either as webfonts or in our source, just for logo reliability purposes. But maybe that's just because I'm not fond of the font we have chosen, and irrelevant at this point.
Also, the text/logo should be aligned either with either the center or baseline (not sure which) of other content in the header, and it looks right now like it's aligned with the top.
referenced this pull request
Dec 11, 2011
Thanks for your patience - you do take your life into your hands, working on these things with nitpicky people like me. This is looking nice.
Try this base.css, and tell me what you think. It makes significantly fewer changes, which I think may account for some of the difference between your experience and mine.
All these issues are a consequence of all the elements in the header being text of moderately similar size, but in different containers. This would not be a problem if they were of sufficiently different size, or were separated by sufficient distance, or if our 'logo' were not plain text.
Now my only disappointment is with the fact that we have chosen a font that makes the 'logo' (IP[y]:) part look very nice, but is pretty poor for actual text. But I think that ship sailed long ago, and is not pertinent here.
Since we intend to ultimately redo most of the UI elements we have right now, I shouldn't be too picky. So I think this can go in as is with my minor adjustments if you think they are sensible, after you revert the bundling of the font, which isn't being used anymore.
I'm totally fine with your css. I've rebase the whole thing and force pushed.
I've also added the logo source, not sure if it is very usefull. All in 3 commits so you can just cherry-pick or throw away when you'll be ok with merging.